Skip to content

i18n(ja): restore lost code fences (batch 2, 37 files) - #23506

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-lost-code-fences-sweep-batch2
Aug 13, 2026
Merged

i18n(ja): restore lost code fences (batch 2, 37 files)#23506
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-lost-code-fences-sweep-batch2

Conversation

@yahonda

@yahonda yahonda commented Aug 12, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Second batch of a corpus-wide sweep fixing a structural MT regression (batch 1: #23505): many config/log/command/output examples in Japanese translations lost their triple-backtick code fences entirely, degrading to plain (sometimes still-indented) text with no syntax highlighting or copy-button UI. The example content itself was untouched — only the fence markers were missing.

This PR (37 files) restores the fences to match the English source exactly:

  • Fence markers (plain or taggedyaml/sql/shell/```json) added back at the correct position and indentation.
  • Body content re-indented where it had accumulated stray leading whitespace from the old workaround (Markdown's "4-space indented code block" convention, used as a substitute once the real fence was lost) — every file's fence count and per-line indentation now matches the English source exactly.
  • No translated prose, headings, or any other content was touched.

Verified mechanically for every file in this PR: (1) the count of ``` occurrences matches the English source exactly, and (2) for every matched code block, per-line leading-whitespace matches the English source exactly, including code fences nested inside blockquotes.

Disjoint file set from #23505 (batch 1) — the two PRs can be reviewed/merged independently. A further batch of the remaining ~179 candidate files will follow separately.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Continues the corpus-wide fence-restoration sweep (see PR pingcap#23505,
batch 1). Same method: fence markers restored to match English
exactly, including per-line indentation correction. Verified via the
fence-count + positional (blockquote-aware) indentation check across
all 37 files -- no remaining mismatches.

4 files from this batch's original scope (dm/dm-manage-schema.md,
dm/handle-failed-ddl-statements.md,
dm/manually-handling-sharding-ddl-locks.md, privilege-management.md)
were still incomplete when this batch was interrupted and are
reverted to their original state, to be redone cleanly in a future
batch rather than committing partial/inconsistent edits.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 09a498c0-d8ef-4c59-8b5a-0477eabbfb84

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 12, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 12, 2026
Found via a deeper content-level indentation check (comparing every
line inside every fenced block against the English source, not just
the fence markers themselves) run while reviewing this PR:

- pd-control.md: 8 closing/opening brace lines inside JSON example
  blocks ended up mis-indented by this batch's own fix pass (some were
  already correctly indented before this batch touched the file and
  got de-indented in the process; others were left with a stale
  leading indent on just the first line of a block). All now match
  the English source's indentation exactly.
- performance-tuning-methods.md: fix one missing を particle
  (`close`呼び出します -> `close`を呼び出します) found in the same file
  while re-checking it.

Verified via an exhaustive fenced-block content diff against the
English source across all 37 files in this PR: 0 remaining mismatches.
Also verified no merge conflicts against the other open
i18n-ja-release-8.5 PRs (pingcap#23509, pingcap#23511, pingcap#23512).
@yahonda
yahonda marked this pull request as ready for review August 13, 2026 01:37
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-13 03:13:33.699433399 +0000 UTC m=+3275399.735528455: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 13, 2026
@qiancai
qiancai merged commit fcaa418 into pingcap:i18n-ja-release-8.5 Aug 13, 2026
4 of 9 checks passed
yahonda added a commit to yahonda/docs that referenced this pull request Aug 13, 2026
Found via user spot-checks across the current i18n-ja-release-8.5
branch; fixed every confirmed defect and swept the corpus for
recurrences of each pattern.

- Restore literal English SQL function names in headings that had
  been mistranslated as Japanese prose (SLEEP() -> 寝る(), VALUES() ->
  値(), CASE -> 場合, IF() -> もし(), and 15 more across
  miscellaneous-functions.md, information-functions.md, and
  control-flow-functions.md). Verified corpus-wide via an anchor-based
  heading comparison against the English source: 0 remaining
  instances of this pattern after the fix.
- Fix 3 missing が particles after code-span identifiers
  (string-functions.md x2, partitioned-table.md) and one misplaced を
  particle (encryption-at-rest.md's --s3.sse argument).
- Fix a meaning-inverting heading/sentence in partitioned-table.md
  ("partitioned table" -> "partitioned table" instead of "partitioned
  table" -> "non-partitioned table").
- Unify "rotate the master key" heading to ローテーションする, matching
  the ロ​ーテーション term used in the very next sentence and dominant
  throughout the rest of the corpus (回転させる was a self-contradicting
  outlier).
- Restore 4 more lost code fences in pd-control.md that a previous
  batch (pingcap#23506) missed, and fix newly-discovered lost fences in
  performance-tuning-methods.md (3), performance-tuning-overview.md
  (1, plus translating its formula to match the rest of the file),
  pipelined-dml.md (1), and performance-schema-session-connect-attrs.md
  (2) -- none of which were in the original corpus-wide sweep list,
  suggesting daily syncs keep reintroducing this defect in newly
  translated content.
- Unify 5 inconsistent renderings of the "Queries Using Plan Cache
  OPS" Grafana panel name in performance-tuning-methods.md to the one
  form the sync bot itself already left correctly in English.

Verified no merge conflicts against all other open i18n-ja-release-8.5
PRs (pingcap#23506, pingcap#23509, pingcap#23511).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants