Skip to content

i18n(ja): restore lost code fences (batch 1, 135 files) - #23505

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-lost-code-fences-sweep
Aug 12, 2026
Merged

i18n(ja): restore lost code fences (batch 1, 135 files)#23505
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-lost-code-fences-sweep

Conversation

@yahonda

@yahonda yahonda commented Aug 12, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

First batch of a corpus-wide sweep fixing a structural MT regression: many config/log/command/output examples in Japanese translations lost their triple-backtick code fences entirely, degrading to plain (sometimes still-indented) text with no syntax highlighting or copy-button UI. The example content itself was untouched — only the fence markers were missing.

This PR (135 files) restores the fences to match the English source exactly:

  • Fence markers (plain or taggedyaml/sql/shell/```json) added back at the correct position and indentation.
  • Body content re-indented where it had accumulated stray leading whitespace from the old workaround (Markdown's "4-space indented code block" convention, used as a substitute once the real fence was lost) — every file's fence count and per-line indentation now matches the English source exactly.
  • No translated prose, headings, or any other content was touched.

Verified mechanically for every file in this PR: (1) the count of occurrences matches the English source exactly, and (2) for every matched code block, per-line leading-whitespace matches the English source exactly, including code fences nested inside blockquotes (`> ... > ``` ), which need their own check since a naive leading-whitespace comparison does not catch indentation drift after a > ` marker.

An earlier round of independent review found and fixed two defect classes the initial automated verification missed: (1) one file where a pre-existing fence-indentation quirk broke the verification script's block-parser and caused the whole file to be silently skipped, leaving ~26 blocks with stale indentation; (2) two files with the blockquote-nested-fence blind spot described above. Both are now fixed and covered by the verification method for all files in this PR.

This is the first of several planned batches — a larger candidate list (~216 more files) remains and will follow in subsequent PRs (see #23506 for batch 2). See the tracking note for full scope and method.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Part of a corpus-wide sweep for a structural MT regression: many
config/log/command/output examples in ja translations lost their
triple-backtick code fences entirely, degrading to plain (sometimes
still-indented) text with no syntax highlighting or copy-button UI.
Restored fences to match the English source exactly, including
re-indenting fence markers and body content that had accumulated
stray leading whitespace from the old indented-code-block workaround.
Every file's fence count and per-line indentation now matches the
English source exactly; content itself is untouched.

This is the first of several batches; ~216 more candidate files
remain in the queue (see memory: ja-lost-code-fences-sweep).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/develop This PR relates to the area of TiDB App development. labels Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 460a6776-18f1-40e8-9da4-1fc7c2513813

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 12, 2026
An independent review of the batch-1 fence restoration found 2 defect
classes the automated verification missed:

- check-before-deployment.md: 84 lines across ~26 command-output
  blocks retained a stale 4-space indent from the old workaround,
  not matching English's flush indentation. This file's fence tag
  itself had a pre-existing indentation quirk that broke the
  original block-pairing script's parser, causing the whole file to
  be silently skipped by the automated indentation-fix pass.
- ai/guides/connect.md and develop/dev-guide-connection-parameters.md:
  2 blockquote-nested fenced blocks (`> ``` ... > ``` `) had stale
  extra indentation immediately after the `> ` marker, which the
  original indentation checker's plain leading-whitespace comparison
  didn't detect (the line doesn't start with whitespace, it starts
  with `>`).

Verified via a corpus-wide blockquote-aware line-by-line indentation
check across all 135 files in this PR - no further issues found.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda marked this pull request as ready for review August 12, 2026 05:32
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2026
yahonda added a commit to yahonda/docs that referenced this pull request Aug 12, 2026
Continues the corpus-wide fence-restoration sweep (see PR pingcap#23505,
batch 1). Same method: fence markers restored to match English
exactly, including per-line indentation correction. Verified via the
fence-count + positional (blockquote-aware) indentation check across
all 37 files -- no remaining mismatches.

4 files from this batch's original scope (dm/dm-manage-schema.md,
dm/handle-failed-ddl-statements.md,
dm/manually-handling-sharding-ddl-locks.md, privilege-management.md)
were still incomplete when this batch was interrupted and are
reverted to their original state, to be redone cleanly in a future
batch rather than committing partial/inconsistent edits.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda marked this pull request as draft August 12, 2026 05:50
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2026
@yahonda yahonda changed the title i18n(ja): restore lost code fences (batch 1, 135 files) i18n(ja): restore lost code fences (batches 1-2, 172 files) Aug 12, 2026
@yahonda
yahonda force-pushed the i18n-ja-lost-code-fences-sweep branch from 844d0df to 4694046 Compare August 12, 2026 05:55
@yahonda yahonda changed the title i18n(ja): restore lost code fences (batches 1-2, 172 files) i18n(ja): restore lost code fences (batch 1, 135 files) Aug 12, 2026
@yahonda
yahonda marked this pull request as ready for review August 12, 2026 06:21
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 12, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 12, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-12 08:58:57.696711539 +0000 UTC m=+3209723.732806616: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit 46285fa into pingcap:i18n-ja-release-8.5 Aug 12, 2026
5 of 14 checks passed
@yahonda
yahonda deleted the i18n-ja-lost-code-fences-sweep branch August 13, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants