Skip to content

Push expressions through layout plans - #9166

Closed
joseph-isaacs wants to merge 1 commit into
vortex-plan-rulesfrom
vortex-plan-optimizer
Closed

Push expressions through layout plans#9166
joseph-isaacs wants to merge 1 commit into
vortex-plan-rulesfrom
vortex-plan-optimizer

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Superseded by #9196

The parent-reduction rule framework and all concrete expression-pushdown/plan-optimization rules are now one signed-off commit and one review unit in #9196.

No implementation was removed: the combined #9196 commit has the same Git tree as this PR's previous head. This PR is closed, and #9187 now targets vortex-plan-rules directly.

@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 7 improved benchmarks
❌ 1 regressed benchmark
✅ 1954 untouched benchmarks
⏩ 89 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cold_misaligned[(64, 256)] 4.4 ms 5 ms -11.64%
Simulation search_index_in_range_chunked 6.8 ms 5.6 ms +21.96%
Simulation slice_primitive_tight_loop[10000] 503.7 µs 420.1 µs +19.88%
Simulation search_index_above_max_chunked 5.6 ms 4.8 ms +15.33%
Simulation slice_dict_tight_loop[10000] 813.9 µs 715.9 µs +13.68%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=1024/indices=1000] 6 ms 5.3 ms +13.2%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=1024/indices=256] 2.3 ms 2 ms +12.61%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=16384/indices=1000] 10 ms 9 ms +11.1%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing vortex-plan-optimizer (956389d) with vortex-plan-rules (82141f9)2

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on vortex-plan-rules (a1e7377) during the generation of this report, so f8ab498 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@joseph-isaacs
joseph-isaacs marked this pull request as ready for review August 4, 2026 11:52
@joseph-isaacs
joseph-isaacs marked this pull request as draft August 4, 2026 11:52
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from 4dced78 to 7968c7e Compare August 4, 2026 16:48
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from 7968c7e to a9043d5 Compare August 5, 2026 14:35
@joseph-isaacs
joseph-isaacs changed the base branch from vortex-plan to vortex-plan-rules August 5, 2026 14:36
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from a9043d5 to bda6747 Compare August 6, 2026 09:27
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from bda6747 to 042e358 Compare August 6, 2026 12:41
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from 2028928 to 0134c4b Compare August 6, 2026 20:40
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from 0134c4b to 6c41c35 Compare August 6, 2026 23:58
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from 6c41c35 to 65aad23 Compare August 7, 2026 12:04
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from 65aad23 to 265f6c2 Compare August 7, 2026 15:33
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from 265f6c2 to b121a9e Compare August 7, 2026 15:57
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from b121a9e to 0e24b8f Compare August 7, 2026 16:05
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch 2 times, most recently from 50778e9 to be85e95 Compare August 10, 2026 12:53
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from be85e95 to f1a1d88 Compare August 10, 2026 13:47
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs
joseph-isaacs force-pushed the vortex-plan-optimizer branch from 9a87561 to 956389d Compare August 12, 2026 10:41

Copy link
Copy Markdown
Contributor Author

Superseded by #9196. The parent-reduction rule API and all concrete expression-pushdown/plan-optimization rules are now one signed-off commit and one review unit in #9196. No implementation was dropped: the combined commit's tree is byte-for-byte identical to this PR's previous head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant