Skip to content

feat: improve thought segments syntax extraction - #636

Merged
giladgd merged 25 commits into
masterfrom
gilad/adaptToBreakingChanges
Aug 9, 2026
Merged

feat: improve thought segments syntax extraction#636
giladgd merged 25 commits into
masterfrom
gilad/adaptToBreakingChanges

Conversation

@giladgd

@giladgd giladgd commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description of change

  • feat: improve thought segment syntax extraction
  • feat: expose the model's architecture directly on the model instance
  • feat: expose download speed and ETA for a model downloader
  • feat: export gguf file quant names
  • fix: adapt to breaking llama.cpp changes
  • fix(LlamaContextSequence): make .dispose() return a promise
  • fix: Qwen chat wrapper auto thought segment opening
  • fix: optimize checkpoints with auto opening thought segments
  • fix: map GgmlType configs directly from native code
  • fix: simulator model dispose while in use race conditions
  • fix: safer cleanup flows
  • fix: bugs
  • refactor: Vulkan device memory readings
  • docs: add type links

Fixes #634
Fixes #637 (native object disposal race conditions)
Fixes #629 (native object disposal race conditions)
Fixes #623

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd
giladgd requested a review from ido-pluto August 4, 2026 05:17
@giladgd giladgd self-assigned this Aug 4, 2026
… thinking segment opening in a generation prompt
@JoshuaWise

JoshuaWise commented Aug 5, 2026

Copy link
Copy Markdown

Okay! This PR is perfect. You probably got a bunch of notifications in your email from previous comments I made which I've deleted because I realized they were wrong. I didn't realize additionalRenderParameters.enable_thinking was replaced by reasoning in this PR, so my testing was off. Ignore all my previous comments. This PR perfectly addresses #634 and I'm stupid. Thank you for the fix!

@ido-pluto ido-pluto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd
giladgd merged commit 3f686d7 into master Aug 9, 2026
21 checks passed
@giladgd
giladgd deleted the gilad/adaptToBreakingChanges branch August 9, 2026 06:35
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 3.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment