fix: dropped generation-prompt text in JinjaTemplateChatWrapper - #635
Open
JoshuaWise wants to merge 1 commit into
Open
fix: dropped generation-prompt text in JinjaTemplateChatWrapper#635JoshuaWise wants to merge 1 commit into
JoshuaWise wants to merge 1 commit into
Conversation
Member
|
Thanks for the PR! |
giladgd
reviewed
Aug 4, 2026
| ) | ||
| ], | ||
| ...( | ||
| noPrefixTrigger != null |
Member
There was a problem hiding this comment.
We need to make sure that we don't force-open a thought segment on every render, we should only do it when the model response is empty because we're just starting to generate it.
The rendering also happens after function calls are done (when the results are being put in the context), after context shifts, and some other edge cases, so we shouldn't break those
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
JinjaTemplateChatWrapperwas discarding text in the template's generation prompt that comes after the assistant role header. Any static text the template emits between the role header and the model's content -- most importantly a pre-filled reasoning tag like<think>was silently dropped. This PR fixes that behavior, enabling many templates that rely on pre-filling a<think>tag to force the model into reasoning mode, or<think></think>to suppress it.Fixes #634
Pull-Request Checklist
masterbranchnpm run formatto apply eslint formattingnpm run testpasses with this changeFixes #0000