Skip to content

Clarify cluster Delete comment: terminates, does not remove #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewnester merged 1 commit into from
Jul 24, 2026
+2 −1
Merged

Clarify cluster Delete comment: terminates, does not remove #6044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bundle/direct/dresources/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func (r *ResourceCluster) DoUpdate(ctx context.Context, id string, config *Clust
return nil, err
} else if !desiredStarted && alreadyRunning {
// lifecycle.started=false: fire Delete; WaitAfterUpdate polls for TERMINATED.
// Delete does not remove the cluster, it just sets the state to TERMINATED.
// Note: Delete terminates the cluster; permanent removal is a separate API (permanent-delete).
_, err := r.client.Clusters.Delete(ctx, compute.DeleteCluster{ClusterId: id})
return nil, err
}
Expand Down Expand Up @@ -231,6 +231,7 @@ func (r *ResourceCluster) WaitAfterCreate(ctx context.Context, id string, config

if config.Lifecycle != nil && config.Lifecycle.Started != nil && !*config.Lifecycle.Started {
// started=false: terminate the cluster after it reaches RUNNING.
// Note: Delete terminates the cluster; permanent removal is a separate API (permanent-delete).
deleteWaiter, err := r.client.Clusters.Delete(ctx, compute.DeleteCluster{ClusterId: id})
if err != nil {
return nil, err
Expand Down
Loading