Clarify cluster Delete comment: terminates, does not remove#6044
Merged
Conversation
Reworded both Clusters.Delete call sites in cluster.go to state that Delete terminates the cluster and that permanent removal is a separate API, so the next reader doesn't misread it as removing the cluster. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 8be6b6f
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 4 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading
bundle/direct/dresources/cluster.go, theClusters.Deletecalls in thelifecycle.started=falsepaths looked like they might remove the cluster rather than just terminate it. The naming is easy to misread.This is a comment-only change. Reworded both
Clusters.Deletecall sites to state that Delete terminates the cluster and that permanent removal is a separate API, so the next reader does not hit the same confusion.This pull request and its description were written by Isaac.