fix(security): Scope MCP UI resource caches by server name#3801
fix(security): Scope MCP UI resource caches by server name#3801charlesvien wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
Reviews (1): Last reviewed commit: "scope MCP UI resource caches by server n..." | Re-trigger Greptile |
9e370a3 to
cfc8cd8
Compare
06757d0 to
c22b78a
Compare
cfc8cd8 to
f9ddf14
Compare
c22b78a to
fa76c61
Compare
f9ddf14 to
65696c3
Compare
|
Note 🤖 stamphog reviewed This changes MCP resource-cache scoping and tool-call authorization to fix a security vulnerability — squarely security-sensitive surface — but has no independent review; the only signal is a bot reaction, not a substantive approval.
Gate mechanics and policy version
Updated in place — this replaces 2 earlier stamphog review(s) on this PR. |
fa76c61 to
a19203b
Compare
65696c3 to
5dadd74
Compare
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
5dadd74 to
315b4a2
Compare

Problem
Resolves VERIA-352: cross-server MCP UI cache poisoning and capability confusion.
Changes
Key the MCP UI resource caches by (server, uri) so a malicious server can't serve HTML/metadata for a trusted server's resource, and make app tool authorization fail closed so only tools that declared a UI (or opted in with
ui.visibility"app") can be invoked from app HTML.How did you test this?
Unit tests in
@posthog/core: cross-server cache isolation, per-server in-flight dedup, and the fail-closed authorization cases.Automatic notifications