fix(security): Keep OAuth token out of terminal environments#3799
Open
charlesvien wants to merge 1 commit into
Open
fix(security): Keep OAuth token out of terminal environments#3799charlesvien wants to merge 1 commit into
charlesvien wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
Author
This was referenced Jul 24, 2026
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
charlesvien
marked this pull request as ready for review
July 24, 2026 20:57
Contributor
|
Reviews (1): Last reviewed commit: "keep OAuth token out of terminal environ..." | Re-trigger Greptile |
charlesvien
force-pushed
the
fix/veria-351-oauth-token-terminal-leak
branch
2 times, most recently
from
July 24, 2026 22:01
a70ae4d to
992320d
Compare
|
|
charlesvien
force-pushed
the
fix/veria-351-oauth-token-terminal-leak
branch
from
July 25, 2026 23:50
992320d to
ccf5a68
Compare
charlesvien
force-pushed
the
fix/veria-351-oauth-token-terminal-leak
branch
from
July 26, 2026 00:58
ccf5a68 to
1f4c436
Compare
|
Note 🤖 stamphog reviewed Gates denied this PR (deny-list match on auth-adapter code, tier classified T2-never) and the change touches OAuth token/credential handling in shell environments — security-sensitive surface with no independent human or agent review approving it.
Gate mechanics and policy version
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Resolves VERIA-351: OAuth access token leak in terminal shell environments.
Changes
Stop writing the OAuth token to the shared process env, and scrub the credential vars from the shell/pty env so repo scripts can't read them.
How did you test this?
Unit tests in
@posthog/workspace-server(shell env scrubbing, incl. viaadditionalEnv, and the auth adapter).Automatic notifications