GitHub Issue 1470: Manage Templates end up with sample type not usable in Apps - #7985
Open
XingY wants to merge 5 commits into
Open
GitHub Issue 1470: Manage Templates end up with sample type not usable in Apps#7985XingY wants to merge 5 commits into
XingY wants to merge 5 commits into
Conversation
…d default (#7974) ## Rationale LabKey/internal-issues#899 Saving a grid view from a subfolder currently resolves the view inherited from an ancestor folder, edits it in place, and then on save relocates it — so the subfolder save destroys the parent's inherited default. The fix threads a new explicitTargetContainer flag through both save actions: unless the caller explicitly named a target folder, an ancestor-owned view found by the lookup is discarded so a new local view shadows it instead. On the client, SaveViewModal stops offering/sending inherit outside the app home folder, and reads inherit/shared off the new server-supplied shadowed sub-object (a session view is never itself shared or inheritable, so its own flags were always wrong defaults). ## Related Pull Requests - #7974 - LabKey/labkey-ui-components#2066 - LabKey/limsModules#2427 ## Changes - Save grid view fix for saving/resolving inherited view when target folder provided
labkey-alan
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
query-UpdateQueryImportTemplate.api uses query.querydef.metadata to store user configured custom import templates in XML. The query name was provided by the client. When a query name with a different casing is provided, it successfully resolves the table. However, saving a query.querydef record with table name that doesn't strictly match the actual query name casing results in App fail to load metadata for this table.
This PR uses the resolved schema/query name when saving query.querydef for UpdateQueryImportTemplate, instead of user provided values.
Related Pull Requests
Changes