GitHub Issue 1470: Manage Templates end up with sample type not usable in Apps - #2067
Open
XingY wants to merge 2 commits into
Open
GitHub Issue 1470: Manage Templates end up with sample type not usable in Apps#2067XingY wants to merge 2 commits into
XingY wants to merge 2 commits into
Conversation
labkey-alan
approved these changes
Aug 27, 2026
labkey-alan
left a comment
labkey-alan
left a comment
Contributor
There was a problem hiding this comment.
Overall this looks good, but I would use useLoadableState in the added hook to cut down on boilerplate.
| const [queryInfo, setQueryInfo] = useState<QueryInfo>(); | ||
| const [error, setError] = useState<string>(); | ||
| const [notFound, setNotFound] = useState(false); | ||
| const [loadingState, setLoadingState] = useState<LoadingState>(LoadingState.INITIALIZED); |
Contributor
There was a problem hiding this comment.
I would recommend using useLoadableState which will handle most of the boilerplate in this hook around tracking loading state.
Edit: Actually it would probably be even more concise to use useQueryInfo
Contributor
There was a problem hiding this comment.
Yes, I was going to say. useQueryInfo is very similar to this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes
useSourceTypeParamanduseSampleTypeParamhooks to get resolved data type names with correct casing from url paraminvalidateQueryDetailsCachehad anexactKeyMatchcode path that's never used, this PR removes itinvalidateQueryDetailsCacheto remove case insensitive keys