Aligning Error.mapResultFuturebehavior with other implementations of Result.mapResultFuture - #708
Open
Myllyenko wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
============================================
+ Coverage 71.91% 72.40% +0.49%
- Complexity 3474 3521 +47
============================================
Files 390 391 +1
Lines 16220 16339 +119
Branches 1698 1702 +4
============================================
+ Hits 11664 11831 +167
+ Misses 3904 3866 -38
+ Partials 652 642 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Myllyenko
force-pushed
the
fix/result-error-map-result-future
branch
from
August 23, 2026 19:42
ce1276a to
155ef22
Compare
Error.mapResultFuture was the only Result implementation that completed the returned future exceptionally: Fail, Unexpected and even Error.mapStatusFuture all hand back a completed future carrying the failure. That made the outcome of Result.compose(...) depend on which flavour of failure it was chaining, and it threw NullPointerException outright for a result built with Result.error(message, null), because CompletableFuture rejects a null exception. Return a completed future with this error result instead.
Myllyenko
force-pushed
the
fix/result-error-map-result-future
branch
from
August 23, 2026 19:43
155ef22 to
446af94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error.mapResultFuturewas the onlyResultimplementation that completed the returned future exceptionally:Fail,Unexpectedand evenError.mapStatusFutureall hand back a completed future carrying the failure. That made the outcome ofResult.compose(...)depend on which flavour of failure it was chaining, and it threwNullPointerExceptionoutright for a result built withResult.error(message, null), becauseCompletableFuturerejects anullexception.