Assembly x64: fix comparison to be unsigned - #11104
Merged
Merged
Conversation
Contributor
Author
|
Code generated by PR: |
SparkiDev
force-pushed
the
asm_x64_large_len_fix
branch
from
August 10, 2026 15:07
7c2bd39 to
8eaef1f
Compare
Large values of lengths were being compared as signed values. When the length is over 2GiB, the check was wrong.
Assembly code PR merged after signed comparison fixup.
SparkiDev
force-pushed
the
asm_x64_large_len_fix
branch
from
August 12, 2026 22:10
8eaef1f to
641253e
Compare
Contributor
Author
|
Jenkins: retest this please Aborted |
wolfSSL-Fenrir-bot
approved these changes
Aug 18, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11104
Scan targets checked: wolfcrypt-port-bugs
No new issues found in the changed files. ✅
philljj
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Large values of lengths were being compared as signed values.
When the length is over 2GiB, the check was wrong.
Fixes zd#22283, zd#22286