Guard IdentifyAsn1Key test on TEST_INTERNAL - #1157
Merged
Merged
Conversation
- IdentifyAsn1Key is WOLFSSH_LOCAL, so the check and its DER blob only build when linking the test library.
ejohnstown
requested review from
philljj and
wolfSSL-Fenrir-bot
and
a lite review from Copilot
August 11, 2026 16:28
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the API test suite to only compile/link the IdentifyAsn1Key-based assertion when internal test symbols are available, matching IdentifyAsn1Key’s WOLFSSH_LOCAL visibility and avoiding non-internal build/link failures.
Changes:
- Guard the RSA SubjectPublicKeyInfo DER test blob with
WOLFSSH_TEST_INTERNAL. - Guard the
IdentifyAsn1Keyassertions intest_wolfSSH_ReadPublicKey_pem()withWOLFSSH_TEST_INTERNAL. - Clarify the comment explaining why this check is internal-only.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1157
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
philljj
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IdentifyAsn1Key is WOLFSSH_LOCAL, so the check and its DER blob only build when linking the test library.