Skip to content

feat(vortex-spatial): add area scalar function - #9203

Merged
HarukiMoriarty merged 5 commits into
developfrom
nemo/geo-area
Aug 10, 2026
Merged

feat(vortex-spatial): add area scalar function#9203
HarukiMoriarty merged 5 commits into
developfrom
nemo/geo-area

Conversation

@HarukiMoriarty

@HarukiMoriarty HarukiMoriarty commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a native GeoArea scalar function backed by geo::Area::unsigned_area
  • support every native geometry dtype, including zero-area point and line families and rectangular boxes
  • preserve input nullability and propagate null rows through unary columnar execution
  • give every geo scalar function a local operand validator that checks exact arity before dtype validation
  • parameterize repeated Area, Envelope, and MakeLine cases with rstest for clearer per-dtype failures and broader operand-order coverage

Semantics

This follows DuckDB ST_Area semantics over the native Vortex geometry types: point and line families return zero, polygon holes are subtracted, multipolygon component areas are summed, rectangles use width times height, and higher coordinate dimensions are ignored. WKB remains excluded because it is a storage representation rather than a native decoded geometry.

@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 1949 untouched benchmarks
🆕 7 new benchmarks
⏩ 89 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cold_misaligned[(64, 256)] 4.4 ms 5.3 ms -16.88%
Simulation decompress[u64, (1000, 16)] 73.6 µs 65 µs +13.16%
Simulation compress_fsst[(1000, 64, 8)] 1.2 ms 1 ms +13.04%
🆕 Simulation column_x_column N/A 212.7 µs N/A
🆕 Simulation column_x_constant N/A 586.6 µs N/A
🆕 Simulation nullable_columns N/A 234.6 µs N/A
🆕 Simulation multipolygon N/A 2.7 ms N/A
🆕 Simulation nullable_polygon N/A 1.4 ms N/A
🆕 Simulation polygon_with_holes N/A 2.3 ms N/A
🆕 Simulation simple_polygon N/A 1 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing nemo/geo-area (0f145ec) with develop (9157d6c)2

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (c61095f) during the generation of this report, so 9157d6c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@HarukiMoriarty HarukiMoriarty added the changelog/feature A new feature label Aug 5, 2026
@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-area branch 2 times, most recently from 40f4666 to 90ee99b Compare August 6, 2026 20:13
@HarukiMoriarty HarukiMoriarty changed the title feat(vortex-geo): add area scalar function feat(vortex-spatial): add area scalar function Aug 7, 2026

@connortsui20 connortsui20 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really need to get my rowfn stuff in

Base automatically changed from nemo/geo-native-bbox-precheck to develop August 10, 2026 17:24
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
HarukiMoriarty merged commit ff0a26d into develop Aug 10, 2026
73 of 74 checks passed
@HarukiMoriarty
HarukiMoriarty deleted the nemo/geo-area branch August 10, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants