fix(evaluation): preserve trace boundaries in eval sets - #907
Open
linhongyu510 wants to merge 1 commit into
Open
fix(evaluation): preserve trace boundaries in eval sets#907linhongyu510 wants to merge 1 commit into
linhongyu510 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix trace-to-eval-set conversion when a tracing file contains more than one trace.
Previously, conversion state such as
conversation,app_name, anduser_idwas shared across trace groups, whileeval_cases.append()ran after the grouping loop. This could collapse multiple traces into one eval case and mix tool calls or metadata across trace boundaries.This change:
start_timebefore deriving input, output, and tool orderThe regression test uses two interleaved, out-of-order traces and verifies that conversations, tool calls, metadata, and timestamps remain isolated.
Validation
.venv/bin/python -m pytest tests/test_evaluator.py -q— 3 passedruff check veadk/evaluation/base_evaluator.py tests/test_evaluator.pyruff format --check veadk/evaluation/base_evaluator.py tests/test_evaluator.pygit diff --checkAI assistance
This change was developed with AI assistance. I reviewed the trace grouping logic, rebased it onto the latest
main, and ran the checks above.