Initialize the document locator before starting tokenization#124
Open
sideshowbarker wants to merge 1 commit into
Open
Initialize the document locator before starting tokenization#124sideshowbarker wants to merge 1 commit into
sideshowbarker wants to merge 1 commit into
Conversation
Problem: When a caller supplies its own ContentHandler, the Document system identifier is null. Cause: tokenizer.initLocation() wasn’t getting called until after Driver.tokenize() called tokenizer.start(). So the tokenizer’s systemId/ publicId were still null when start() delivered the first SAX events. Fix: Call initLocation() before start(). The locator carries the input source’s public/system IDs before any downstream handler observes it. Fixes #123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When a caller supplies its own
ContentHandler, the Document system identifier is null.Cause:
tokenizer.initLocation()wasn’t getting called until afterDriver.tokenize()calledtokenizer.start(). So the tokenizer’ssystemId/publicIdwere still null whenstart()delivered the first SAX events.Fix: Call
initLocation()beforestart(). The locator carries the input source’s public/system IDs before any downstream handler observes it. Fixes #123.