gnu: list the tests excluded from the pass/fail percentages - #13891
gnu: list the tests excluded from the pass/fail percentages#13891sylvestre wants to merge 3 commits into
Conversation
| # getmntent/mtab - purely so the interception lands. | ||
|
|
||
| cp/nfs-removal-race.log # overrides __xstat/stat; std uses statx | ||
| dd/fail-ftruncate-fstat.log # overrides ftruncate/fstat |
There was a problem hiding this comment.
Can we change it to use strace at upstream?
There was a problem hiding this comment.
sure, don't hesitate to submit a pr upstream
| dd/fail-ftruncate-fstat.log # overrides ftruncate/fstat | ||
| df/skip-duplicates.log # needs HAVE_GETMNTENT, overrides fopen on the mtab | ||
| nproc/nproc-quota.log # overrides sched_getscheduler | ||
| rm/rm-readdir-fail.log # overrides readdir; std uses readdir64 |
There was a problem hiding this comment.
Maybe, try to change upstream to use strace.
Merging this PR will improve performance by 3.47%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | complex_relative_date |
330.6 µs | 318.6 µs | +3.77% |
| ⚡ | Simulation | ls_recursive_balanced_tree[(6, 4, 15)] |
120.7 ms | 117 ms | +3.17% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing sylvestre:gnu-unfixable-tests (f525254) with main (4ca7ded)2
Footnotes
-
50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(668ea71) during the generation of this report, so 4ca7ded was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com>
da3a655 to
87c096b
Compare
There was a problem hiding this comment.
Pull request overview
Adds a curated list of GNU test-suite cases that should be excluded from uutils’ pass/fail percentage calculations (as consumed by the coreutils-tracking repository), focusing on tests that are structurally impossible or depend on GNU-specific implementation details rather than observable user behavior.
Changes:
- Introduces
util/gnu-unfixable-tests.txtdocumenting the rationale and listing excluded GNU test.logentries. - Categorizes exclusions (structural impossibility vs. libc-entry-point interception assumptions) to clarify why they’re excluded.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
used by https://github.com/uutils/coreutils-tracking/