Skip to content

gnu: list the tests excluded from the pass/fail percentages - #13891

Open
sylvestre wants to merge 3 commits into
uutils:mainfrom
sylvestre:gnu-unfixable-tests
Open

gnu: list the tests excluded from the pass/fail percentages#13891
sylvestre wants to merge 3 commits into
uutils:mainfrom
sylvestre:gnu-unfixable-tests

Conversation

@sylvestre

@sylvestre sylvestre commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Comment thread util/gnu-unfixable-tests.txt Outdated
Comment thread util/gnu-unfixable-tests.txt Outdated
# getmntent/mtab - purely so the interception lands.

cp/nfs-removal-race.log # overrides __xstat/stat; std uses statx
dd/fail-ftruncate-fstat.log # overrides ftruncate/fstat

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change it to use strace at upstream?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, don't hesitate to submit a pr upstream

Comment thread util/gnu-unfixable-tests.txt Outdated
dd/fail-ftruncate-fstat.log # overrides ftruncate/fstat
df/skip-duplicates.log # needs HAVE_GETMNTENT, overrides fopen on the mtab
nproc/nproc-quota.log # overrides sched_getscheduler
rm/rm-readdir-fail.log # overrides readdir; std uses readdir64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, try to change upstream to use strace.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@codspeed-hq

codspeed-hq Bot commented Aug 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.47%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 351 untouched benchmarks
⏩ 50 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation complex_relative_date 330.6 µs 318.6 µs +3.77%
Simulation ls_recursive_balanced_tree[(6, 4, 15)] 120.7 ms 117 ms +3.17%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing sylvestre:gnu-unfixable-tests (f525254) with main (4ca7ded)2

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (668ea71) during the generation of this report, so 4ca7ded was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

sylvestre and others added 2 commits August 13, 2026 18:51
Copilot AI lite review requested due to automatic review settings August 13, 2026 16:51
@sylvestre
sylvestre force-pushed the gnu-unfixable-tests branch from da3a655 to 87c096b Compare August 13, 2026 16:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a curated list of GNU test-suite cases that should be excluded from uutils’ pass/fail percentage calculations (as consumed by the coreutils-tracking repository), focusing on tests that are structurally impossible or depend on GNU-specific implementation details rather than observable user behavior.

Changes:

  • Introduces util/gnu-unfixable-tests.txt documenting the rationale and listing excluded GNU test .log entries.
  • Categorizes exclusions (structural impossibility vs. libc-entry-point interception assumptions) to clarify why they’re excluded.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread util/gnu-unfixable-tests.txt Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 13, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants