Skip to content

[Dashboard] Remove the Solana access-token upgrade path - #8920

Merged
0xFirekeeper merged 1 commit into
mainfrom
dashboard/remove-solana-token-upgrade
Aug 27, 2026
Merged

[Dashboard] Remove the Solana access-token upgrade path#8920
0xFirekeeper merged 1 commit into
mainfrom
dashboard/remove-solana-token-upgrade

Conversation

@0xFirekeeper

@0xFirekeeper 0xFirekeeper commented Aug 27, 2026

Copy link
Copy Markdown
Member

Removes the one-off migration that reissued a project's vault access tokens in place to add Solana scopes, and the client-side vault plumbing that existed only to serve it.

Projects created before Solana support are not stranded: rotating the admin key reissues both the management and wallet tokens under the current policy set, which already includes the Solana read/create/sign policies. The Solana tab now points at Vault instead of rendering the upgrade form.

Changes

  • Remove upgradeAccessTokensForSolana and its helpers (createWalletAccessToken, createManagementAccessToken, hashSecretKey, bufferToHex) from transactions/lib/vault.client.ts
  • Delete upgrade-solana-permissions.client.tsx and replace its render site in server-wallets-table.client.tsx with a pointer to Rotate Admin Key
  • Remove initVaultClient, now uncalled
  • Drop NEXT_PUBLIC_THIRDWEB_VAULT_URL from public-envs.ts and .env.example
  • Drop the @thirdweb-dev/vault-sdk dependency (and its knip.json ignore entry)

transactions/lib/vault.client.ts keeps createProjectServerWallet, updateDefaultProjectWallet, and maskSecret, which have other callers and already route through api-server.

The dashboard no longer imports @thirdweb-dev/vault-sdk anywhere; every vault operation goes through @/actions/vault.

Verification

  • npx tsc --noEmit — exit 0
  • npx biome check on changed files — only the repo's pre-existing CRLF format diagnostics (untouched files report the same); no lint or organizeImports findings
  • npx eslint on changed files — exit 0
  • npx knip — exit 0

PR-Codex overview

This PR focuses on removing the @thirdweb-dev/vault-sdk dependency and refactoring related code to manage Solana wallet permissions differently. It simplifies the handling of vault access tokens and modifies the UI to provide clearer guidance for users regarding Solana access.

Detailed summary

  • Removed NEXT_PUBLIC_THIRDWEB_VAULT_URL from .env.example and public-envs.ts.
  • Deleted upgrade-solana-permissions.client.tsx.
  • Updated ServerWalletsTable to display a message instead of using UpgradeSolanaPermissions.
  • Removed vault SDK-related imports and functions from vault.client.ts.
  • Streamlined the management of access tokens for Solana wallets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

The one-off upgrade that reissued a project's vault access tokens in place
to add Solana scopes is no longer needed: rotating the admin key reissues
both tokens under the current policy set, which already covers Solana.

Dropping its last caller leaves no client-side vault usage, so the vault
client, its base URL env var, and the vault SDK dependency go with it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@0xFirekeeper
0xFirekeeper requested review from a team as code owners August 27, 2026 02:55
@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7140f31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
thirdweb-www Ready Ready Preview Aug 27, 2026 3:01am
4 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs-v2 Skipped Skipped Aug 27, 2026 3:01am
nebula Skipped Skipped Aug 27, 2026 3:01am
thirdweb_playground Skipped Skipped Aug 27, 2026 3:01am
wallet-ui Skipped Skipped Aug 27, 2026 3:01am

@github-actions github-actions Bot added the Dashboard Involves changes to the Dashboard. label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

On-demand reviews are free for the next 25 days. After that, they cost $0.25 per reviewed file.

Or wait 6 minutes for your next included review.

View limit details

Limit details: You’ve used all 3 included reviews currently available. Your 40 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 89e799ae-c470-415a-aeaa-5bdeb14cb8de

📥 Commits

Reviewing files that changed from the base of the PR and between f915a53 and 7140f31.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • apps/dashboard/.env.example
  • apps/dashboard/knip.json
  • apps/dashboard/package.json
  • apps/dashboard/src/@/constants/public-envs.ts
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/components/server-wallets-table.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/lib/vault.client.ts
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/transactions/solana-wallets/components/upgrade-solana-permissions.client.tsx

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@0xFirekeeper
0xFirekeeper merged commit 04d8c12 into main Aug 27, 2026
22 of 23 checks passed
@0xFirekeeper
0xFirekeeper deleted the dashboard/remove-solana-token-upgrade branch August 27, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant