[Dashboard] Remove the Solana access-token upgrade path - #8920
Conversation
The one-off upgrade that reissued a project's vault access tokens in place to add Solana scopes is no longer needed: rotating the admin key reissues both tokens under the current policy set, which already covers Solana. Dropping its last caller leaves no client-side vault usage, so the vault client, its base URL env var, and the vault SDK dependency go with it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
On-demand reviews are free for the next 25 days. After that, they cost $0.25 per reviewed file. Or wait 6 minutes for your next included review. View limit detailsLimit details: You’ve used all 3 included reviews currently available. Your 40 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
Comment |
size-limit report 📦
|
Removes the one-off migration that reissued a project's vault access tokens in place to add Solana scopes, and the client-side vault plumbing that existed only to serve it.
Projects created before Solana support are not stranded: rotating the admin key reissues both the management and wallet tokens under the current policy set, which already includes the Solana read/create/sign policies. The Solana tab now points at Vault instead of rendering the upgrade form.
Changes
upgradeAccessTokensForSolanaand its helpers (createWalletAccessToken,createManagementAccessToken,hashSecretKey,bufferToHex) fromtransactions/lib/vault.client.tsupgrade-solana-permissions.client.tsxand replace its render site inserver-wallets-table.client.tsxwith a pointer to Rotate Admin KeyinitVaultClient, now uncalledNEXT_PUBLIC_THIRDWEB_VAULT_URLfrompublic-envs.tsand.env.example@thirdweb-dev/vault-sdkdependency (and itsknip.jsonignore entry)transactions/lib/vault.client.tskeepscreateProjectServerWallet,updateDefaultProjectWallet, andmaskSecret, which have other callers and already route through api-server.The dashboard no longer imports
@thirdweb-dev/vault-sdkanywhere; every vault operation goes through@/actions/vault.Verification
npx tsc --noEmit— exit 0npx biome checkon changed files — only the repo's pre-existing CRLFformatdiagnostics (untouched files report the same); no lint ororganizeImportsfindingsnpx eslinton changed files — exit 0npx knip— exit 0PR-Codex overview
This PR focuses on removing the
@thirdweb-dev/vault-sdkdependency and refactoring related code to manage Solana wallet permissions differently. It simplifies the handling of vault access tokens and modifies the UI to provide clearer guidance for users regarding Solana access.Detailed summary
NEXT_PUBLIC_THIRDWEB_VAULT_URLfrom.env.exampleandpublic-envs.ts.upgrade-solana-permissions.client.tsx.ServerWalletsTableto display a message instead of usingUpgradeSolanaPermissions.vault.client.ts.