Conversation
Allow hosts to define ZEROERR_NO_MAIN, return non-zero from UnitTest::run on failure, export PUBLIC includes, discover libFuzzer link dirs via clang++ -print-runtime-dir, and fix MSVC __VA_ARGS__ forwarding plus should_fail/may_fail exit accounting.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Modified the ZEROERR_PRINT_ASSERT macro to allow for empty message arguments by using an empty string as a pattern. This change ensures compatibility with Windows and Clang, preventing assertion failures when no additional format arguments are provided. Added a regression test to verify this behavior.
Updated the ZEROERR_CREATE_TEST_FUNC and TEST_CASE macros to include warning suppression around the function definition. This change improves the usability of the test framework by ensuring that warnings are properly managed during test case creation.
Introduced a new `is_complete_type` trait to ensure SFINAE fails for incomplete types, addressing GCC's strict subscripting rules. Updated the `is_array` trait to handle pointers to complete types separately, improving type safety and usability in template metaprogramming.
Dispatch on is_pointer before any [0] check so VkImageView/SDL_Window* no longer hard-error inside void_t during ASSERT printing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.