Daily And Sport Activities Dataset and Classification Task - #1053
Open
niampattni wants to merge 6 commits into
Open
Daily And Sport Activities Dataset and Classification Task#1053niampattni wants to merge 6 commits into
niampattni wants to merge 6 commits into
Conversation
niampattni
marked this pull request as ready for review
April 21, 2026 11:56
niampattni
marked this pull request as draft
April 21, 2026 12:53
niampattni
marked this pull request as ready for review
April 21, 2026 13:49
- fixed test_task_window_larger_than_signal_raises, _sliding_windows now raises error - fixed "datasetes" typo in docs/api/datasets.rst - fixed missing "::" in docs/api/datasets/pyhealth.datasets.DailyAndSportActivities.rst - fixed typo in docstring "Activitiesy"
jhnwu3
requested changes
May 24, 2026
jhnwu3
left a comment
jhnwu3
left a comment
Collaborator
There was a problem hiding this comment.
Tldr; your dataset class can be much simpler given your .yaml file.
|
|
||
| class DailyAndSportActivitiesDataset(BaseDataset): | ||
| """ | ||
| PyHealth dataset for Daily and Sports Activities data. |
Collaborator
There was a problem hiding this comment.
hey niam, sorry for the late reply, some quick thoughts:
the load_data() is pretty redundant. The way PyHealth.base_dataset works is after you write your metadata file defining how to load each file or map to each feature/file for your pyhealth.task, you can just write a .yaml file and have it be loaded. See this example: https://github.com/sunlabuiuc/PyHealth/blob/master/pyhealth/datasets/covid19_cxr.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authors: Niam Pattni (npattni2@illinois.edu) and Sezim Zamirbekova (szami2@illinois.edu)
Dataset
Paper
Overview
This PR adds a dataset and classification task for the Daily and Sports Activities dataset. Below is a description of the implementation, including lists of all file changes for review.
Dataset
Files
pyhealth/datasets/daily_sport_activities.pypyhealth/datasets/__init__.pypyhealth/datasets/configs/daily_sport_activities.yamldocs/api/datasets.rstdocs/api/datasets/pyhealth.datasets.DailyAndSportActivities.rstDescription
BaseDatasetclass.Task
Files
pyhealth/tasks/daily_sport_activities.pypyhealth/tasks/__init__.pydocs/api/tasks.rstdocs/api/tasks/pyhealth.tasks.DailyAndSportActivity.rstDescription
Example
Files
examples/daily_sport_activities.ipynbDescription
Tests
Files
tests/core/test_daily_sport_activities.pyDescription
Uses dummy data to fully test dataset and task functionality including: