test: migrate math/base/special/falling-factorial to ULP-based assertions - #13927
Merged
Conversation
…rtions Replaces the computed relative-tolerance assertions in the fixture loops with `@stdlib/assert/is-almost-same-value`. The ULP bounds correspond to the measured minimum ULP difference over each full fixture set for both the JavaScript and native implementations. Ref: #11352 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/falling-factorialfrom relative tolerance testing (delta <= tol, wheretol = C * EPS * abs( expected[ i ] )) to ULP difference testing using@stdlib/assert/is-almost-same-value.test/test.jsandtest/test.native.js.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires from both test files.Each of the three fixture-based test bodies declares a single named
ulpsconstant, and each assertion uses thet.strictEqual( isAlmostSameValue( y, expected[ i ], ulps ), true, 'returns expected value' )shape.The ULP bounds are the measured minimum over each full fixture set (1000 cases per fixture):
xfixtures/cpp/large.json80.0 * EPS116xfixtures/cpp/small.json80.0 * EPS117xfixtures/cpp/negative.json100.0 * EPS150Notes on how the bounds were determined:
isAlmostSameValue, taking the per-fixture maximum.lib/main.js) and the native implementation (lib/native.js, built viamake install-node-addons). Both implementations yield identical maxima, sotest.jsandtest.native.jsuse the same values.test.jsreports 3014/3014 passing andtest.native.jsreports 3011/3011 passing on both runs.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Only the two test files are changed; no
package.jsonor source changes were required.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. It studied the migration idiom from previously merged conversions, applied the migration, measured the minimum ULP bounds for both the JavaScript and native implementations, and verified tightness and determinism locally.
@stdlib-js/reviewers
Generated by Claude Code