test: migrate math/base/special/hypot to ULP-based assertions - #13926
Merged
Conversation
Resolves a part of #11352. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Planeshifter
marked this pull request as ready for review
August 5, 2026 01:03
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
test/test.jsandtest/test.native.jsofmath/base/special/hypotfrom relative-tolerance (EPS-based) assertions to ULP-difference assertions via@stdlib/assert/is-almost-same-value, using the minimum required ULP value.'the function computes the hypotenuse'test, which iterates over the./fixtures/julia/data.jsonfixture (2003 cases). Direct ULP-difference computation over the fixture (via@stdlib/number/float64/base/ulp-difference), using both the JavaScript implementation and a locally built native add-on, shows a maximum measured difference of2ULPs for both.N = 1was confirmed to fail (16 of 2003 fixture cases), so2is the minimum integer bound for which all cases pass.'the function computes the hypotenuse (canonical inputs)'block and all other test blocks in both files already use exactt.strictEqualcomparisons on exactly-representable values and are left unchanged, per the demonstrated idiom in the tracking issue.EPSandabsrequires anddelta/tolvariables.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Both the JavaScript and native (
test.native.js, run against a locally built add-on) test suites pass in full (2031 assertions each), run twice at the final ULP bound to confirm determinism (no FMA/arch flakiness observed).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by an automated Claude Code agent running as a scheduled routine: it selected an unconverted package, studied the merged prior art for this migration (e.g.
math/base/special/hypotf,math/base/special/pow,math/base/special/acosh), performed the ULP-difference migration, and empirically determined the minimum ULP bound by direct measurement against the fixture data (including building and testing against a native add-on), with the bound and its determinism independently re-verified before opening this PR.@stdlib-js/reviewers
Generated by Claude Code