Skip to content

refactor: Extract apply and update status steps - #811

Merged
adwk67 merged 8 commits into
mainfrom
feat/smooth-operator/extract-apply-step
Aug 11, 2026
Merged

refactor: Extract apply and update status steps#811
adwk67 merged 8 commits into
mainfrom
feat/smooth-operator/extract-apply-step

Conversation

@adwk67

@adwk67 adwk67 commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

This PR covers the following:

  • extracts apply and update_status steps
  • moves secret creation to the apply step

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Comment thread rust/operator-binary/src/hdfs_controller.rs Outdated
Comment thread rust/operator-binary/src/controller/apply.rs
@adwk67 adwk67 self-assigned this Jul 31, 2026
@adwk67
adwk67 marked this pull request as ready for review July 31, 2026 11:08
@adwk67

adwk67 commented Jul 31, 2026

Copy link
Copy Markdown
Member Author
--- PASS: kuttl (741.03s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.4_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (327.98s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.4_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (159.48s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.5_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (184.41s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.5_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (741.02s)
PASS

@siegfriedweber
siegfriedweber self-requested a review August 4, 2026 11:55
@adwk67 adwk67 closed this Aug 10, 2026
@adwk67 adwk67 reopened this Aug 10, 2026
@adwk67

adwk67 commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

Openshift tests to verify clusterrole:

--- PASS: kuttl (277.83s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.4_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-true (277.32s)
PASS

Comment thread rust/operator-binary/src/controller/apply.rs Outdated
Comment thread rust/operator-binary/src/crd/mod.rs

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67
adwk67 added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit ab13f82 Aug 11, 2026
18 checks passed
@adwk67
adwk67 deleted the feat/smooth-operator/extract-apply-step branch August 11, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants