Skip to content

feat(chart) :: draw vertical reference lines - #1376

Draft
81reap wants to merge 3 commits into
sqlpage:mainfrom
81reap:reference/2-vertical-lines
Draft

feat(chart) :: draw vertical reference lines#1376
81reap wants to merge 3 commits into
sqlpage:mainfrom
81reap:reference/2-vertical-lines

Conversation

@81reap

@81reap 81reap commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Motivation

#1374

Description

  • xline is yline for the x axis
  • When time is set, an xline is a date or a timestamp. On a chart with text labels on the x axis, it is one of those labels.
  • y_reference_lines generalizes into reference_lines to take in rows of x and y reference lines
  • Document the three parameters, add a "Marking events" example (a deploy and an incident on a latency chart), and extend the changelog entry.

Testing

  • One new browser test: a time chart draws a line and a label for every xline row it receives.

  1. fix(chart) :: line series up on a category axis for every chart type #1371 :: fix(chart) :: line series up on a category axis for every chart type
  2. feat(chart) :: draw horizontal reference lines #1375 :: feat(chart) :: draw horizontal reference lines
  3. feat(chart) :: draw vertical reference lines #1376 :: feat(chart) :: draw vertical reference lines ← this PR
  4. feat(chart) :: turn a reference line into a band #1377 :: feat(chart) :: turn a reference line into a band

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant