fix(map) :: ignore map coordinates that are not a pair of numbers - #1368
Merged
Conversation
This was referenced Aug 8, 2026
81reap
marked this pull request as draft
August 8, 2026 23:17
81reap
marked this pull request as ready for review
August 10, 2026 15:27
lovasoa
requested changes
Aug 10, 2026
lovasoa
left a comment
Collaborator
There was a problem hiding this comment.
Just ignoring instead of throwing makes the issue harder to debug for the developer, doesn't it? I'd be okay with logging an error to the console instead of blocking all rendering, but I'd rather not silently swallow errors
Contributor
Author
|
that's a fair call out. I will make the changes and push up a fix once I get home from work |
81reap
force-pushed
the
stack/3-map-coords
branch
from
August 10, 2026 18:57
3aeeb46 to
9115594
Compare
Contributor
Author
|
turns out i had my laptop on me. pushed up a fix during my lunch break |
lovasoa
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
parseCoordsreturns whateverNumber.parseFloatgives it, so"48.8"becomes[48.8]and"north"becomes[NaN].Description
parseCoordsreturnsundefinedunless it parsed exactly two finite numbers.createMarkerreturnsundefinedfor a marker it cannot place, and the caller skips it.tests/end-to-end/map-component.spec.ts, covering a well-formed centre and marker, a centre and a marker with no longitude, and a centre that is not numeric at all.Testing
npm testchecks 37 files and reports nothing.no console errors on card pagefails for the reason described in fix(biome.js) :: fix remaining lint issues #1366, on this branch and on the unmodified base alike.GitHub cannot base a pull request on a branch that lives in a fork, so all eight target
mainand each one carries the commits of those above it. Review and merge them in order: