Migrate ReflectivePropertyAccessor to use Property's four param constructor to avoid unneeded resolveName() call - #37129
Closed
lbkulinski wants to merge 1 commit into
Conversation
…ructor to avoid unneeded resolveName() call Signed-off-by: Logan Kulinski <lbkulinski@gmail.com>
lbkulinski
force-pushed
the
reflective-property-accessor-ctor-migration
branch
from
August 12, 2026 01:13
d3ff644 to
a7a5d5b
Compare
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
status: declined
Member
|
Closing for the reasons given in #37123 (comment). For future reference, PRs like this must include tests that fail before the changes and pass after the changes. |
Author
|
Noted! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the constructor migration mentioned in #37123. Since we already know the name of the property in
ReflectivePropertyAccessor,Property's four argument constructor is used to avoid theresolveName()call.