Allow Maven run and start goals to use test classes - #51100
Closed
henriquejsza wants to merge 1 commit into
Closed
Conversation
Closes spring-projectsgh-36115 Signed-off-by: henriquejsza <henriquejsza@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks for the PR but I don't think we should mix the two in the same attribute. I've been looking at this and would like to fix this differently. Please see the original issue for more details. |
snicoll
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Maven plugin's
useTestClasspathparameter currently accepts a boolean andtrueonly adds test-scoped dependencies. This means that thestartgoal cannot launch an application whose main class is intarget/test-classes.This updates the parameter to support
OFF,DEPENDENCIES, andALL. The legacy valuesfalseandtrueremain aliases forOFFandDEPENDENCIES, respectively.ALLaddstarget/test-classesbeforetarget/classesand includes test-scoped dependencies for bothrunandstart. Unit and integration tests cover mode parsing, backwards compatibility, classpath ordering, and launching from test classes.Closes gh-36115