Skip to content

[RNE Rewrite] refactor(cpp): cleanup core and extension error handling and formatting - #1378

Merged
barhanc merged 4 commits into
rne-rewritefrom
@bh/cpp-core-cleanup
Aug 24, 2026
Merged

[RNE Rewrite] refactor(cpp): cleanup core and extension error handling and formatting#1378
barhanc merged 4 commits into
rne-rewritefrom
@bh/cpp-core-cleanup

Conversation

@barhanc

@barhanc barhanc commented Aug 22, 2026

Copy link
Copy Markdown
Member

Description

  • Removes dead code and fix formatting in core (dtype, schema, tensor, tensor_helpers)
  • Fixes exception shadowing in extension ops (cv, math, nlp, speech)
  • Normalizes error propagation and prefixes across C++ extensions

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

N/A

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@barhanc barhanc self-assigned this Aug 22, 2026
@msluszniak
msluszniak self-requested a review August 23, 2026 08:25

@msluszniak msluszniak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, but other than that it is 👌🏻

Comment thread packages/react-native-executorch/cpp/extensions/cv/image_ops.cpp
@barhanc
barhanc force-pushed the @bh/cpp-core-cleanup branch from 9e2c303 to f2ca60c Compare August 24, 2026 12:32
@barhanc
barhanc merged commit 6d5a997 into rne-rewrite Aug 24, 2026
3 checks passed
@barhanc
barhanc deleted the @bh/cpp-core-cleanup branch August 24, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants