chore: fix VersionInfoProvider bugs, drop stale RegFree.targets entry, thin opsx prompts

[johnml1135]

This branch pulls three unrelated fixes out of #964 (the Avalonia migration
branch), where they had been bundled in by mistake: a set of
VersionInfoProvider bugs (frozen copyright year, wrong assembly
resolution, non-defensive version parsing), a stale build-file reference to
a retired COM class, and 11 .github/prompts/opsx-*.prompt.md files
rewritten to delegate to their matching .claude/skills/openspec-* skill
instead of repeating the same instructions inline.

The obvious question for a three-in-one bundle like this is why it isn't
three PRs -- it's the size of the diff that argues against splitting further,
not the relatedness of the changes: each piece is small, self-contained, and
independently testable, and none of them are Avalonia-migration-specific, so
keeping #964 scoped to the migration mattered more than keeping this cleanup
maximally atomic. This has already been through one review round: a prior
pass flagged that the retired-COM-class cleanup only covered
RegFree.targets and missed BuildInclude.targets/mkall.targets; that gap
is now closed (verified below), and #989, the PR that would have collided
with the RegFree.targets line, was closed as a duplicate.

Where to look

• VersionInfoProvider.cs -- the three bug fixes, pinned by 6 new tests in
  VersionInfoProviderTests.cs that link the real generated
  CommonAssemblyInfo.cs, so they exercise the shipped attribute shapes
  rather than a fake.
• Build/mkall.targets -- the one remaining stale ManagedVwWindow CLSID
  exclusion; grepping the tree for ManagedVwWindow today returns nothing,
  in any *.targets file, on this branch or on main.
• .github/prompts/opsx-*.prompt.md (11 files) -- each now delegates to its
  matching .claude/skills/openspec-*/SKILL.md; every target skill
  directory was confirmed to exist.
• AGENTS.md -- documents the gitlint title/body-length limits CI enforces,
  since several commits in this branch's own history tripped them.

Deliberately not here

• kDefaultCopyrightString/kSensitiveCopyrightString moved from const
  to static readonly (needed to compute the year at runtime) is a
  binary-compat change for any out-of-repo consumer that inlined the old
  const -- confirmed no in-repo caller does.
• The sensitive-mode copyright strip
  (.Replace("SIL International", string.Empty)) is literal, not
  pattern-based: fine against today's fixed template, but would leak a
  future suffix (e.g. a city name) into "sensitive" output. Flagged in
  review, left as a documented trade-off rather than churning the diff
  further.

Extracted from #964, not stacked on it. Rebased onto main today (58
commits behind). ./build.ps1 and
./test.ps1 -TestProject "Src/Common/FwUtils/FwUtilsTests" -TestFilter "VersionInfoProviderTests"
both clean on the rebased tree: Test Run Successful. Total tests: 6.

---

Reading this a year from now -- start here

This PR went through a real review round before this rebase: a prior pass
found a MEDIUM issue (the ManagedVwWindow.dll cleanup was incomplete) and
two LOW nits, and a follow-up commit fixed the MEDIUM one. That follow-up
commit's SHA (and the original bug-finding commit's SHA) are cited in the
PR's older comments but are no longer reachable history after this rebase
-- trust the grep in "Where to look" above over the old SHAs, which is why
this description states the fix as a verified-in-tree fact rather than a
commit reference.

Decisions, and why

Why RegFree.targets shows no diff against main. The original version
of this branch removed a stale ManagedVwWindow.dll entry from
Build/RegFree.targets. A separate PR (#989) touched the same line
independently; #989 was closed as a duplicate once this branch's fix was
confirmed to cover the same ground, and by the time this branch was rebased
onto the current main, that line's content already matched -- so the
rebase folded it to a no-op automatically. Nothing was lost; there is
simply nothing left to show.

Why the MEDIUM issue needed a second commit. The first pass only edited
RegFree.targets, whose ManagedVwWindow.dll fallback entry is gated by
Condition="'@(ManagedComAssemblies)' == ''". FieldWorks.exe never hit
that fallback: Src/Common/FieldWorks/BuildInclude.targets populated
ManagedComAssemblies explicitly, with its own ManagedVwWindow.dll entry,
so the main executable kept emitting a "Could not find file" warning
regardless of the RegFree.targets edit. The follow-up removed that
BuildInclude.targets entry and the matching stale CLSID exclusion in
Build/mkall.targets.

Why the two LOW nits were left alone. Both are pre-existing-pattern
trade-offs rather than bugs introduced by this branch: the const ->
static readonly change is required to compute the copyright year at
runtime, and a repo-wide grep confirmed no consumer depends on it being a
compile-time constant. The literal-string copyright strip matches the
current fixed template exactly; making it pattern-based would be defending
against a template change that has not happened, at the cost of a more
fragile regex today.

Evidence

• ./build.ps1 succeeds on the rebased branch.
• ./test.ps1 -TestProject "Src/Common/FwUtils/FwUtilsTests" -TestFilter "VersionInfoProviderTests" -- Test Run Successful. Total tests: 6,
  covering the copyright-year, assembly-resolution, and trailing-whitespace
  fixes.
• grep -rn "ManagedVwWindow" --include="*.targets" . returns no matches
  on this branch, matching main.
• Every .github/prompts/opsx-*.prompt.md file's target skill name resolves
  to an existing .claude/skills/openspec-*/ directory (checked all 11).

---

This change is

[github-actions]

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 47s ⏱️ +12s
5 766 tests +6  5 685 ✅ +6  81 💤 ±0  0 ❌ ±0 
5 775 runs  +6  5 694 ✅ +6  81 💤 ±0  0 ❌ ±0 

Results for commit d129ff8. ± Comparison against base commit f2fac18.

♻️ This comment has been updated with latest results.

[jasonleenaylor]

Looks good, Devin noted that ManagedVwWindow.dll was removed from RegFree.targets defaults but is still present in FieldWorks.exe BuildInclude.targets

@jasonleenaylor reviewed 14 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on johnml1135).

[johnml1135]

Code review (automated deep review, verified against the code)

Overall: the core VersionInfoProvider bug fixes are correct and well-tested — verified each against the real generated attribute shapes (ApplicationVersion now reads m_assembly rather than always the entry assembly; the trailing-space leak from the empty $FWBETAVERSION case is fixed by the IsNullOrWhiteSpace guard; MajorVersion no longer emits "9.3 STABILITY"/"9.3 "; copyright years are computed at runtime). The new VersionInfoProviderTests link the real CommonAssemblyInfo.cs, so they exercise the shipped attribute shapes. The 11 opsx stubs delegate to skill names that all map to existing .claude/skills/openspec-*/ dirs. Nice.

A few points:

MEDIUM — the RegFree cleanup is only half-done, and overlaps PR #989

This PR removes ManagedVwWindow.dll from Build/RegFree.targets, but that entry sits in the fallback ItemGroup gated by Condition="'@(ManagedComAssemblies)' == ''". For FieldWorks.exe the list is populated explicitly in Src/Common/FieldWorks/BuildInclude.targets:10 (which still contains <ManagedComAssemblies Include="$(OutDir)ManagedVwWindow.dll" />), so the fallback never applied to the main executable — it will keep emitting the Could not find file ...ManagedVwWindow.dll warning. The retire-linux-era-view-shims change (task 5.1, marked done) names both files; only RegFree.targets was done. Suggest also removing BuildInclude.targets:10 (and the stale CLSID-exclusion comment at Build/mkall.targets:46).

Also note: this RegFree.targets edit is the same line PR #989 removes (there it's replaced with an explanatory comment). The two PRs will conflict / one becomes a no-op — worth deciding which one carries the RegFree change and dropping it from the other. The removal is genuinely useful for LCMBrowser/GenerateHCConfig/UnicodeCharEditor/ComManifestTestHost, which hit the fallback path.

LOW / nit — const → static readonly is a (minor) binary-compat change

VersionInfoProvider.cs:23-28: kDefaultCopyrightString/kSensitiveCopyrightString are public and moved from const to static readonly. Necessary to compute the year at runtime, and I confirmed the only in-repo references are within VersionInfoProvider + the new test (no const-context/attribute/case usages), so it's safe here. Flagging only for public-API hygiene — an out-of-repo consumer that inlined the old const would need a recompile.

LOW — sensitive-mode copyright strip is literal

VersionInfoProvider.cs:305: copyRight.Replace("SIL International", string.Empty).TrimEnd(). Strips cleanly against today's fixed template (Copyright (c) 2002-$YEAR SIL International), but brittle if that string ever gains a trailing suffix (e.g. , Dallas), which would leak into "sensitive" output. Future fragility only.

Process note

The test-plan checkboxes (build.ps1, test.ps1 FwUtilsTests) are still unchecked, so passing tests aren't yet evidenced in the description.

_{Reviewed with Claude Code; findings verified against the code at the PR head. No code changed.}

[johnml1135]

Fixed the MEDIUM issue in 5b96437: removed the remaining ManagedVwWindow.dll entry from BuildInclude.targets (which pre-populates ManagedComAssemblies for FieldWorks.exe, bypassing the RegFree.targets fallback) and the matching stale CLSID exclusion in mkall.targets. The RegFree.targets overlap with #989 is moot now — #989 was closed as a duplicate.

Leaving the two LOW nits (const→static readonly, literal copyright strip) as documented trade-offs rather than churning the diff further; flag if you'd like those addressed too.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.05%. Comparing base (f2fac18) to head (d129ff8).

Files with missing lines	Patch %	Lines
Src/Common/FwUtils/VersionInfoProvider.cs	50.00%	2 Missing and 8 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #978   +/-   ##
=======================================
  Coverage   38.04%   38.05%           
=======================================
  Files        1499     1499           
  Lines      350108   350113    +5     
  Branches    40231    40238    +7     
=======================================
+ Hits       133216   133233   +17     
+ Misses     187607   187589   -18     
- Partials    29285    29291    +6     

Files with missing lines	Coverage Δ
Src/Common/FwUtils/VersionInfoProvider.cs	44.85% <50.00%> (+9.73%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.