fix(test): test delete Windows registry accidently - #4918
Conversation
a758fde to
c4635ae
Compare
|
Another thing here is, can we make code format coming along with commits instead of doing formatting in the end commit here. |
This comment has been minimized.
This comment has been minimized.
9be4399 to
360e048
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
360e048 to
dcd1d78
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
@baka-gourd I think this looks quite interesting but would require more work before it can be merged.
Three general principles of our committing style:
- Each commit should do one single thing, whether that is refactoring, introducing a breaking change, or adding a new feature.
- Each commit should ensure that all test cases are passing. If running all tests is not practical in your local environment, you should have run at least all related tests and have made sure that they are passing.
- When a commit indicates a behavioral change that might cause some tests to fail, you should update those influenced tests in the same commit so that they pass again.
6366e7f to
78a2fde
Compare
5bccc07 to
25f7553
Compare
517c610 to
91589c2
Compare
|
The CI error isn't my fault; CI pulled the wrong commit😓 |
|
Lmao, a re-run seems don't fix up the problem with buggy github actions. 😆 |
|
@baka-gourd I think a rebase would help though. |
91589c2 to
e40d5d6
Compare
e40d5d6 to
4baac20
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
-let environment = process.registry_environment_key()?;
+let environment = process.registry_key("Environment", CURRENT_USER)?;I don't think that's a good idea. Even though it only has one function, using inline code will lead to a lot of duplication, which makes it harder to modify later. |
Sorry there might be some GitHub availability issues going on; I'm okay with both the inlined and the non-inlined versions of this call, as long as it's consistent. |
fix #4915
This PR is intended to fix the issue mentioned in the ticket regarding the accidental deletion of existing registry entries. However, while investigating the problem, we also discovered a concurrency issue in RegistryGuard, so the scope of the fix is quite extensive.