Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c9e8eeefc709e1246577d67155300906>>
* @generated SignedSource<<854bb2a573f2c69d495aa1721f903ab0>>
*/

/**
Expand Down Expand Up @@ -379,7 +379,7 @@ public object ReactNativeFeatureFlags {
public fun fuseboxFrameRecordingEnabled(): Boolean = accessor.fuseboxFrameRecordingEnabled()

/**
* Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.
* Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.
*/
@JvmStatic
public fun fuseboxNetworkInspectionEnabled(): Boolean = accessor.fuseboxNetworkInspectionEnabled()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<5c36c0a5e9e67b43016ab02eab0ecd8f>>
* @generated SignedSource<<9b295106ef57d7fa85846c57bb74a090>>
*/

/**
Expand Down Expand Up @@ -51,7 +51,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun enableAndroidTextMeasurementOptimizations(): Boolean = false

override fun enableBridgelessArchitecture(): Boolean = false
override fun enableBridgelessArchitecture(): Boolean = true

override fun enableCppPropsIteratorSetter(): Boolean = false

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d0524c8293f029992b78e4f9479b8a1d>>
* @generated SignedSource<<1664bdb6cd521d608b9bab74df43eb76>>
*/

/**
Expand All @@ -27,8 +27,6 @@ public open class ReactNativeFeatureFlagsOverrides_RNOSS_Canary_Android : ReactN

override fun enableAccessibilityOrder(): Boolean = true

override fun enableBridgelessArchitecture(): Boolean = true

override fun enableIntersectionObserverByDefault(): Boolean = true

override fun enableSwiftUIBasedFilters(): Boolean = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ package com.facebook.react.internal.featureflags
public open class ReactNativeNewArchitectureFeatureFlagsDefaults() :
ReactNativeFeatureFlagsDefaults() {

override fun enableBridgelessArchitecture(): Boolean = true

override fun useNativeViewConfigsInBridgelessMode(): Boolean = true

override fun useTurboModuleInterop(): Boolean = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ const InspectorFlags::Values& InspectorFlags::loadFlagsAndAssertUnchanged()
false,
#endif
.networkInspectionEnabled =
ReactNativeFeatureFlags::enableBridgelessArchitecture() &&
ReactNativeFeatureFlags::fuseboxNetworkInspectionEnabled(),
.perfIssuesEnabled = ReactNativeFeatureFlags::perfIssuesEnabled(),
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ TYPED_TEST(JsiIntegrationPortableTest, ReactNativeApplicationEnable) {
"integrationName": "JsiIntegrationTest",
"unstable_frameRecordingEnabled": false,
"unstable_isProfilingBuild": false,
"unstable_networkInspectionEnabled": false
"unstable_networkInspectionEnabled": true
}
})"));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,6 @@ class ReactNativeFeatureFlagsOverrides
ReactNativeFeatureFlagsDefaults::fuseboxNetworkInspectionEnabled());
}

bool enableBridgelessArchitecture() override {
// NOTE: Network support is gated by (enableBridgelessArchitecture &&
// fuseboxNetworkInspectionEnabled).
return overrides_.networkInspectionEnabled.value_or(
ReactNativeFeatureFlagsDefaults::enableBridgelessArchitecture());
}

bool enableNetworkEventReporting() override {
return overrides_.enableNetworkEventReporting.value_or(
ReactNativeFeatureFlagsDefaults::enableNetworkEventReporting());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<5c7e2061344bf998e5fc6b621af2ff45>>
* @generated SignedSource<<4276ae19d55acb679c9e635122e813b3>>
*/

/**
Expand Down Expand Up @@ -330,7 +330,7 @@ class ReactNativeFeatureFlags {
RN_EXPORT static bool fuseboxFrameRecordingEnabled();

/**
* Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.
* Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.
*/
RN_EXPORT static bool fuseboxNetworkInspectionEnabled();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c511b77030561c7a6655eb512082462c>>
* @generated SignedSource<<2c09412cdf8edaf4f7d6d90a446ce6fa>>
*/

/**
Expand Down Expand Up @@ -84,7 +84,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool enableBridgelessArchitecture() override {
return false;
return true;
}

bool enableCppPropsIteratorSetter() override {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<5d286510a4f8642adcc9d38556dd60dd>>
* @generated SignedSource<<8f83d4d3c457e0f6acda799cfe58144a>>
*/

/**
Expand Down Expand Up @@ -35,10 +35,6 @@ class ReactNativeFeatureFlagsOverridesOSSCanary : public ReactNativeFeatureFlags
return true;
}

bool enableBridgelessArchitecture() override {
return true;
}

bool enableIntersectionObserverByDefault() override {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ namespace facebook::react {

class ReactNativeFeatureFlagsOverridesOSSStable : public ReactNativeFeatureFlagsDefaults {
public:
bool enableBridgelessArchitecture() override
{
return true;
}
bool useNativeViewConfigsInBridgelessMode() override
{
return true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,13 @@ const definitions: FeatureFlagDefinitions = {
ossReleaseStage: 'none',
},
enableBridgelessArchitecture: {
defaultValue: false,
defaultValue: true,
metadata: {
description: 'Feature flag to enable the new bridgeless architecture.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'canary',
ossReleaseStage: 'stable',
},
enableCppPropsIteratorSetter: {
defaultValue: false,
Expand Down Expand Up @@ -673,7 +673,7 @@ const definitions: FeatureFlagDefinitions = {
metadata: {
dateAdded: '2024-01-31',
description:
'Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.',
'Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.',
expectedReleaseValue: true,
purpose: 'experimentation',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<ff39edecf287d3fe3638da2f71e6bd1c>>
* @generated SignedSource<<71e307d568421d49e3943f58c4fcb163>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -270,7 +270,7 @@ export const enableAndroidTextMeasurementOptimizations: Getter<boolean> = create
/**
* Feature flag to enable the new bridgeless architecture.
*/
export const enableBridgelessArchitecture: Getter<boolean> = createNativeFlagGetter('enableBridgelessArchitecture', false);
export const enableBridgelessArchitecture: Getter<boolean> = createNativeFlagGetter('enableBridgelessArchitecture', true);
/**
* Enable prop iterator setter-style construction of Props in C++ (this flag is not used in Java).
*/
Expand Down Expand Up @@ -444,7 +444,7 @@ export const fuseboxEnabledRelease: Getter<boolean> = createNativeFlagGetter('fu
*/
export const fuseboxFrameRecordingEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxFrameRecordingEnabled', false);
/**
* Enable network inspection support in the React Native DevTools CDP backend. Requires `enableBridgelessArchitecture`. This flag is global and should not be changed across React Host lifetimes.
* Enable network inspection support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.
*/
export const fuseboxNetworkInspectionEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxNetworkInspectionEnabled', true);
/**
Expand Down
Loading