gh-153422: Return bool from some tkinter query methods#153429
Merged
serhiy-storchaka merged 1 commit intoJul 9, 2026
Conversation
The winfo_exists(), winfo_ismapped() and winfo_viewable() methods of tkinter widgets and Text.edit_modified() now return a bool instead of an integer or, depending on wantobjects, a string. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Documentation build overview
|
|
GH-153439 is a backport of this pull request to the 3.15 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 9, 2026
GH-153439) The tests for PhotoImage.transparency_get(), Text.debug() and Treeview.exists() now assert the exact bool type, and the documentation and docstrings use "true"/"false" instead of "1"/"0". Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 9, 2026
GH-153439) (GH-153442) The tests for PhotoImage.transparency_get(), Text.debug() and Treeview.exists() now assert the exact bool type, and the documentation and docstrings use "true"/"false" instead of "1"/"0". (cherry picked from commit 1604c80) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
winfo_exists(),winfo_ismapped()andwinfo_viewable()methods of tkinter widgets andText.edit_modified()now return aboolinstead of an integer or, depending onwantobjects, a string.These were the only boolean-valued query methods still returning
int/raw; all the others (tk_busy_status(),winfo_isdark(),Text.compare(),edit_canundo()/edit_canredo(), theselection_present()/selection_includes()methods, the ttkTreeviewpredicates, etc.) already return a properbool. Thewinfo_*methods have coerced the result tointsince the initial revision of tkinter, predating thebooltype.Existing boolean-return tests that only checked truthiness (or compared to
0/1withassertEqual) are tightened to pin the exact type withassertIs.🤖 Generated with Claude Code