gh-90092: Fix test_curses when stdin is write-only (e.g. under nohup)#153420
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-90092: Fix test_curses when stdin is write-only (e.g. under nohup)#153420serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…nohup) newterm() needs a readable input fd, but nohup can leave stdin write-only. Fall back to the output fd, as already done when stdin has no fileno. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_cursesfails insetUp()when the suite is run backgrounded undernohup:setUp()derives thenewterm()input fd from stdin, butnohupleaves stdin write-only when it backgrounds a run started from a terminal, andnewterm()rejects a write-only input fd. Fall back to the output fd in that case, as is already done when stdin has nofileno().This only affects builds using the
newterm()path (ncurses 6.5+); the previousinitscr()path tolerated a write-only stdin.Reported by @weixlu.