gh-153410: Add PyDict_AsFrozenDictAndClear C-API#153413
Open
sobolevn wants to merge 9 commits into
Open
Conversation
sobolevn
requested review from
AA-Turner,
ZeroIntensity,
markshannon and
methane
as code owners
Documentation build overview
|
vstinner
reviewed
Jul 9, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Jul 9, 2026
vstinner
reviewed
Jul 9, 2026
dolfinus
reviewed
Jul 9, 2026
vstinner
approved these changes
Jul 9, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
You should now open an issue in https://github.com/capi-workgroup/decisions/issues/ to ask the C API Working Group to validate the API.
5 tasks
vstinner
reviewed
Jul 9, 2026
| PyDictKeysObject *keys = old->ma_keys; | ||
| PyDictValues *values = old->ma_values; | ||
|
|
||
| // Clear the old dict keys and values, but do not decref them: |
Member
There was a problem hiding this comment.
By the way, the existing similar (but private) _PyList_AsTupleAndClear() has a similar design: first make the list empty, and then create a tuple from the list items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyDict_AsFrozenDictAndClearC-API #153410