gh-98417: Stop modifying PyConfig in sys.set_int_max_str_digits()#152869
Draft
gpshead wants to merge 1 commit into
Draft
gh-98417: Stop modifying PyConfig in sys.set_int_max_str_digits()#152869gpshead wants to merge 1 commit into
gpshead wants to merge 1 commit into
Conversation
|
All commit authors signed the Contributor License Agreement. |
PyConfig is an input to interpreter initialization; the copy stored on PyInterpreterState records how the interpreter was initialized. The runtime int<->str digit limit already lives in PyInterpreterState.long_state.max_str_digits and that is what all readers use, so drop the write-back into interp->config.int_max_str_digits from _PySys_SetIntMaxStrDigits(). As a consequence, interpreters created after a runtime limit change now start from the initially-configured limit instead of inheriting the current runtime value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gpshead
force-pushed
the
claude/cpython-98417-fix-6vqutb
branch
from
7115bfd to
9675274
Compare
zooba
approved these changes
Jul 2, 2026
Member
|
I assume it won't change much on its way out of draft, but provided the change is just removing that line then I'm not going to have any concerns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyConfig is an input to interpreter initialization; the copy stored on PyInterpreterState records how the interpreter was initialized. The runtime int<->str digit limit already lives in
PyInterpreterState.long_state.max_str_digits and that is what all readers use, so drop the write-back into
interp->config.int_max_str_digits from _PySys_SetIntMaxStrDigits().
As a consequence, interpreters created after a runtime limit change now start from the initially-configured limit instead of inheriting the current runtime value.
it's basically a one line change... the question is, is this what we want? we'll resolve that on the issue.