-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
gh-152785: Upgrade Ubuntu from 24.04 to 26.04 in GitHub Actions #152717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
26888b8
38d60de
1501350
5f379bd
e6e0953
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -53,7 +53,7 @@ jobs: | |||||
| name: 'Check if Autoconf files are up to date' | ||||||
| # Don't use ubuntu-latest but a specific version to make the job | ||||||
| # reproducible: to get the same tools versions (autoconf, aclocal, ...) | ||||||
| runs-on: ubuntu-24.04 | ||||||
| runs-on: ubuntu-26.04 | ||||||
| container: | ||||||
| image: ghcr.io/python/autoconf:2025.01.02.12581854023 | ||||||
| timeout-minutes: 60 | ||||||
|
|
@@ -96,7 +96,7 @@ jobs: | |||||
| name: 'Check if generated files are up to date' | ||||||
| # Don't use ubuntu-latest but a specific version to make the job | ||||||
| # reproducible: to get the same tools versions (autoconf, aclocal, ...) | ||||||
| runs-on: ubuntu-24.04 | ||||||
| runs-on: ubuntu-26.04 | ||||||
| timeout-minutes: 60 | ||||||
| needs: build-context | ||||||
| if: needs.build-context.outputs.run-tests == 'true' | ||||||
|
|
@@ -239,18 +239,18 @@ jobs: | |||||
| - false | ||||||
| - true | ||||||
| os: | ||||||
| - ubuntu-24.04 | ||||||
| - ubuntu-24.04-arm | ||||||
| - ubuntu-26.04 | ||||||
| - ubuntu-26.04-arm | ||||||
| exclude: | ||||||
| # Do not test BOLT with free-threading, to conserve resources | ||||||
| - bolt: true | ||||||
| free-threading: true | ||||||
| # BOLT currently crashes during instrumentation on aarch64 | ||||||
| - os: ubuntu-24.04-arm | ||||||
| - os: ubuntu-26.04-arm | ||||||
| bolt: true | ||||||
| include: | ||||||
| # Enable CPU-intensive tests on ARM (default build only) | ||||||
| - os: ubuntu-24.04-arm | ||||||
| - os: ubuntu-26.04-arm | ||||||
| bolt: false | ||||||
| free-threading: false | ||||||
| test-opts: '-u cpu' | ||||||
|
|
@@ -270,7 +270,7 @@ jobs: | |||||
| strategy: | ||||||
| fail-fast: false | ||||||
| matrix: | ||||||
| os: [ubuntu-24.04] | ||||||
| os: [ubuntu-26.04] | ||||||
| ssllib: | ||||||
| # See Tools/ssl/make_ssl_data.py for notes on adding a new version | ||||||
| ## OpenSSL | ||||||
|
|
@@ -346,7 +346,7 @@ jobs: | |||||
| - arch: aarch64 | ||||||
| runs-on: macos-26 | ||||||
| - arch: x86_64 | ||||||
| runs-on: ubuntu-24.04 | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
|
||||||
| runs-on: ${{ matrix.runs-on }} | ||||||
| steps: | ||||||
|
|
@@ -393,7 +393,7 @@ jobs: | |||||
|
|
||||||
| test-hypothesis: | ||||||
| name: "Hypothesis tests on Ubuntu" | ||||||
| runs-on: ubuntu-24.04 | ||||||
| runs-on: ubuntu-26.04 | ||||||
| timeout-minutes: 60 | ||||||
| needs: build-context | ||||||
| if: needs.build-context.outputs.run-ubuntu == 'true' | ||||||
|
|
@@ -504,7 +504,7 @@ jobs: | |||||
| strategy: | ||||||
| fail-fast: false | ||||||
| matrix: | ||||||
| os: [ubuntu-24.04] | ||||||
| os: [ubuntu-26.04] | ||||||
| env: | ||||||
| OPENSSL_VER: 3.5.7 | ||||||
| PYTHONSTRICTEXTENSIONBUILD: 1 | ||||||
|
|
@@ -568,7 +568,7 @@ jobs: | |||||
|
|
||||||
| cross-build-linux: | ||||||
| name: Cross build Linux | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 60 | ||||||
| needs: build-context | ||||||
| if: needs.build-context.outputs.run-ubuntu == 'true' | ||||||
|
|
@@ -650,7 +650,7 @@ jobs: | |||||
|
|
||||||
| all-required-green: # This job does nothing and is only used for the branch protection | ||||||
| name: All required checks pass | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 5 | ||||||
| needs: | ||||||
| - build-context # Transitive dependency, needed to access `run-tests` value | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,7 @@ concurrency: | |||||
|
|
||||||
| jobs: | ||||||
| lint: | ||||||
| runs-on: ubuntu-latest | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need to change these, they don't rely on the version of the underlying system. Less maintenance burden if they are unpinned.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See my question about that in my previous comment: #152717 (comment).
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The lint jobs, docs and libexpat checks don't rely on system tools, I don't think there is a significant risk of updates causing us any issues. Hugo, WDYT?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's keep |
||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 10 | ||||||
|
|
||||||
| steps: | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -49,7 +49,7 @@ concurrency: | |||||
| jobs: | ||||||
| mypy: | ||||||
| name: Run mypy on ${{ matrix.target }} | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 10 | ||||||
| strategy: | ||||||
| fail-fast: false | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,7 +10,7 @@ permissions: | |||||
|
|
||||||
| jobs: | ||||||
| notify-new-bugs-announce: | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| permissions: | ||||||
| issues: read | ||||||
| timeout-minutes: 10 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,7 +11,7 @@ jobs: | |||||
| label-dnm: | ||||||
| name: DO-NOT-MERGE | ||||||
| if: github.repository_owner == 'python' | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| permissions: | ||||||
| pull-requests: read | ||||||
| timeout-minutes: 10 | ||||||
|
|
@@ -28,7 +28,7 @@ jobs: | |||||
| label-reviews: | ||||||
| name: Unresolved review | ||||||
| if: github.repository_owner == 'python' | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| permissions: | ||||||
| pull-requests: read | ||||||
| timeout-minutes: 10 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ env: | |||||
| jobs: | ||||||
| check-c-api-docs: | ||||||
| name: 'Check if all C APIs are documented' | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 5 | ||||||
| steps: | ||||||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ env: | |||||
| jobs: | ||||||
| check-html-ids: | ||||||
| name: 'Check for removed HTML IDs' | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 30 | ||||||
| steps: | ||||||
| - name: 'Check out PR head' | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -19,7 +19,7 @@ permissions: | |||||
| jobs: | ||||||
| cifuzz: | ||||||
| name: ${{ inputs.oss-fuzz-project-name }} (${{ inputs.sanitizer }}) | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 60 | ||||||
| steps: | ||||||
| - name: Build fuzzers (${{ inputs.sanitizer }}) | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -60,7 +60,7 @@ permissions: | |||||
| jobs: | ||||||
| compute-changes: | ||||||
| name: Create context from changed files | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 10 | ||||||
| outputs: | ||||||
| run-android: ${{ steps.changes.outputs.run-android }} | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,7 +17,7 @@ env: | |||||
| jobs: | ||||||
| build-doc: | ||||||
| name: 'Docs' | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 60 | ||||||
| env: | ||||||
| branch_base: 'origin/${{ github.event.pull_request.base.ref }}' | ||||||
|
|
@@ -95,7 +95,7 @@ jobs: | |||||
| # Run "doctest" on HEAD as new syntax doesn't exist in the latest stable release | ||||||
| doctest: | ||||||
| name: 'Doctest' | ||||||
| runs-on: ubuntu-24.04 | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this can be unpinned:
Suggested change
|
||||||
| timeout-minutes: 60 | ||||||
| steps: | ||||||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||||||
|
|
@@ -121,7 +121,7 @@ jobs: | |||||
|
|
||||||
| check-epub: | ||||||
| name: 'Check EPUB' | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| timeout-minutes: 30 | ||||||
| steps: | ||||||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,7 +10,7 @@ permissions: | |||||
| jobs: | ||||||
| stale: | ||||||
| if: github.repository_owner == 'python' | ||||||
| runs-on: ubuntu-latest | ||||||
| runs-on: ubuntu-26.04 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| permissions: | ||||||
| actions: write | ||||||
| pull-requests: write | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.