gh-151944: Fix Sphinx reference warnings in urllib.{parse,request}.rst#152162
Open
lpyu001 wants to merge 4 commits into
Open
gh-151944: Fix Sphinx reference warnings in urllib.{parse,request}.rst#152162lpyu001 wants to merge 4 commits into
urllib.{parse,request}.rst#152162lpyu001 wants to merge 4 commits into
Conversation
bedevere-app
Bot
added
docs
lpyu001
changed the title
lpyu001
changed the title
Documentation build overview
49 files changed ·
|
lpyu001
requested review from
AA-Turner,
StanFromIreland and
hugovk
as code owners
StanFromIreland
changed the title
urllib.{parse,request}.rst
| If the *allow_fragments* argument is false, fragment identifiers are not | ||
| recognized. Instead, they are parsed as part of the path | ||
| or query component, and :attr:`fragment` is set to ``None`` or the empty | ||
| or query component, and :attr:`fragment <SplitResult.fragment>` is set to |
Member
There was a problem hiding this comment.
Suggested change
| or query component, and :attr:`fragment <SplitResult.fragment>` is set to | |
| or query component, and :attr:`~SplitResult.fragment` is set to |
| .. [1] Depending on the value of the *missing_as_none* argument. | ||
|
|
||
| Reading the :attr:`port` attribute will raise a :exc:`ValueError` if | ||
| Reading the :attr:`port <SplitResult.port>` attribute will raise a |
Contributor
Author
There was a problem hiding this comment.
I’ve addressed it，thanks
Member
|
Please also update the headers to be sentence case (https://devguide.python.org/documentation/style-guide/#capitalization): 
|
Contributor
Author
|
Thanks, I’ve addressed your comment. @hugovk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc/library/urllib.{parse,request}.rst#151944