Handle invalid plural index in msgstr[...] instead of raising ValueError (#1209) - #1279
Open
vineethsaivs wants to merge 1 commit into
Open
Handle invalid plural index in msgstr[...] instead of raising ValueError (#1209)#1279vineethsaivs wants to merge 1 commit into
vineethsaivs wants to merge 1 commit into
Conversation
…eError read_po parsed the plural index of a `msgstr[N]` line with `int(idxarg[:-1])`, which leaked a bare `ValueError: invalid literal for int()` to the caller when N was not an integer (e.g. `msgstr[\x0c]`). Route a non-integer index through the parser's existing `_invalid_pofile` handling, so it raises a `PoFileError` when `abort_invalid=True` and otherwise warns and skips the line, consistent with other malformed input. Fixes python-babel#1209
vineethsaivs
force-pushed
the
fix/pofile-invalid-msgstr-index
branch
from
August 27, 2026 16:36
81d0a95 to
ccfa1d9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1279 +/- ##
==========================================
+ Coverage 92.05% 93.37% +1.32%
==========================================
Files 27 27
Lines 4720 4923 +203
==========================================
+ Hits 4345 4597 +252
+ Misses 375 326 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1209.
read_poparses the plural index of amsgstr[N]line withint(idxarg[:-1]). WhenNis not an integer, this leaked a bareValueErrorto the caller:The fix routes a non-integer index through the parser's existing
_invalid_pofilehandling, so it raises aPoFileErrorwhenabort_invalid=Trueand otherwise warns and skips the line, consistent with how other malformed input is handled.Added
test_invalid_msgstr_index_issue_1209(parametrized overabort_invalid), which fails onmaster(bareValueError) and passes with this change.Disclosure: prepared with AI assistance; reviewed by me and I can explain every line.