chore: Update geo trace fitbounds default to 'locations' by camdecoster · Pull Request #7895 · plotly/plotly.js

camdecoster · 2026-07-09T21:27:17Z

Description

Updates the fitbounds default value to "locations" for geo traces. Also fixes (previously unknown) bug related to using zoom buttons with fitbounds active.

Closes #7885

Changes

Changes default
Update schema and types
Persists view attributes to layout
Added check for fitbounds incompatible projections (craig/satellite/albers-usa)
Updates tests per above changes

Videos

Before (fitbounds: false, default)

Screencast.From.2026-07-09.15-30-04.mp4

Before (fitbounds: "locations")

Screencast.From.2026-07-09.16-51-23.mp4

After (fitbounds: "locations", default)

Screencast.From.2026-07-09.15-29-05.mp4

Testing

Be on master
Load Plotly devtools
Open the mock geo_orthographic
Note that the plot is centered on the US/Canada
Switch to this branch
Open the same mock
Note that the plot is now centered on Asia

Notes

fitbounds used to default to false. This changes the default to "locations".
Any plot that wants to maintain the current view calculation will need to pass false to fitbounds
This update matches the convention that most mapping libraries use
The bug (fixed in this PR) meant that zoom button clicks had no effect on the view when fitbounds was active

Follow up work

Antimeridian-aware fitbounds aggregation for choropleth + scattergeo-with-locations
Frame/fit asymmetry for non-clipped fitbounds when midLat ≠ 0 (see geo_first with fitbounds: 'locations')
Account for arcs when computing fitbounds extents (see geo_legendonly),
Antimeridian rotation splitting long lines (see geo_multi-geos)
Enable fitbounds for choroplethmap
Add configurable fitBoundsPadding / maxZoom for map subplot
Updating fitboundsIncompatible projections after baseline review

emilykl · 2026-07-16T20:20:30Z

This test seems somewhat less useful now. Might be worth setting fitbounds: false on this one.

Nah, those dots are great. /s

emilykl · 2026-07-16T20:23:30Z

This test still functions perfectly fine (i.e. if something goes wrong with tick0 for geo plots it will fail), but it might be worth setting a lower zoom level to make it more human-obvious what's going on here. Not a blocker.

I'm going to disable fitbounds for this one as well. It's not helping anyone (or the test) to be so zoomed out.

emilykl · 2026-07-16T20:24:06Z

Do you know why the new image renders a smaller plot? Not a dealbreaker, but the previous version seems better.

Funkiness with projections. This is also running into an issue on my TODO list. For now, I'll disable fitbounds.

emilykl · 2026-07-16T20:25:27Z

How does fitbounds choose a center when the geoJSON wraps all the way around the globe?

It creates one big bounding box around all of the geometry and finds the smallest gap that contains that box. We use d3-geo to figure that out now, but it used to be @turf/bbox, which didn't handle the antimeridian at all.

emilykl · 2026-07-16T20:26:27Z

The top plot doesn't look right, why is the orange line forced to wrap off the right edge?

This is happening because the smallest gap that contains the points (not the line) is what's shown. Adding the lines to the fit check is something I'm looking into.

emilykl · 2026-07-16T20:27:22Z

Green dotted line is cut off the top. Maybe this is an existing limitation with fitbounds, if so, it's not the end of the world but let's open an issue.

I think it's an existing issue and it's on my list to work on in a follow up.

emilykl · 2026-07-16T20:28:37Z

Why this change?

This is due to disallowing fitbounds with the Albers USA projection.

emilykl · 2026-07-16T20:29:18Z

This doesn't seem correct

See my comment here.

emilykl · 2026-07-16T20:30:51Z

It seems not ideal to show less of the southern latitudes when there's no more of the northern latitudes to be shown, would it be possible to add a constraint that the north edge of the map can't be lower than the top of the plot area in the initial render?

It does look a bit odd, but I think it's correct. It's fitting lat/lon, and the lat fit results in the frame getting pulled down. I'll add it to my follow up list. For now I'll disable fitbounds.

emilykl · 2026-07-16T20:31:46Z

This seems incorrect

I've got a fix for this.

emilykl · 2026-07-16T20:32:52Z

Again not totally clear to me how this centerpoint was chosen.

I mean, there's no reason the center has to be the Europe-centric map we're used to, although that does have the advantage of splitting fewer countries in half.

See my comment here.

emilykl · 2026-07-16T20:33:11Z

Same comment here re: centerpoint

There is some funkiness with handling coords around the antimeridian with choropleths. I'm working on a fix, but I think that can wait until after the the v4 release. For now, I'll disable fitbounds for this mock.

emilykl · 2026-07-16T20:34:13Z

Probably another one worth editing the mock to set fitbounds: false

I'll add that and push a fix that should make this look like the original.

emilykl · 2026-07-16T20:34:33Z

What happened here? This seems wrong

It is! I'll add a fix.

emilykl · 2026-07-16T20:34:49Z

This also seems wrong

I disallowed a few projections because the fitbounds math can lead to undesirable results. In this case, the result looks okay, but now it's not using fitbounds due to the disallow list. For now, I think we should keep the disallow list and I can follow up with a more nuanced approach after v4.

camdecoster added 15 commits July 9, 2026 14:41

Linting/formatting

35e356e

Switch default fitbounds to 'locations' for geo traces

2d1a490

Save fitbounds computed values to layout

03c1e43

Persist view attributes during manual zoom operations

a8742c8

Update tests per new default, view attrs saved to layout

9894fdb

Add user view attribute gate for fitbounds

82acb12

Save center lat/lon for clipped projections

0f9af80

Update tests per gate addition

02b0c92

Add draftlog

fe45f65

Replace undefined with null for fitbounds computed values

4f6f122

Use local variables for calculating zoom button actions

c2b23ea

Update tests

93055f0

Update draftlog

5aa17cf

Add test image generation timeout

195345c

Add special handling for Albers USA

f04bc14

camdecoster self-assigned this Jul 15, 2026

camdecoster added 3 commits July 15, 2026 15:58

Add check for projections that don't play well with fitbounds

e470048

Simplify fitbounds default-setting logic

5feb26a

Update baseline images

16254c7

camdecoster marked this pull request as ready for review July 16, 2026 18:59

emilykl reviewed Jul 16, 2026

View reviewed changes

camdecoster added 3 commits July 16, 2026 16:42

Skip fitbounds if axis range has been set

122cdd4

Disable fitbounds for a number of mocks

7dd5c74

Update mocks affected by axis range fix

087b342

Uh oh!

Uh oh!

Conversation

camdecoster commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Videos

Testing

Notes

Follow up work

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camdecoster commented Jul 9, 2026 •

edited

Loading