Skip to content

i18n(ja): fix scrambled global-index note in 3 sql-statement docs - #23510

Closed
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-add-index-global-index-sentence
Closed

i18n(ja): fix scrambled global-index note in 3 sql-statement docs#23510
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-add-index-global-index-sentence

Conversation

@yahonda

@yahonda yahonda commented Aug 13, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Found while reviewing PR #23509 (a daily translation-sync PR): the note about setting a PRIMARY KEY/UNIQUE INDEX/UNIQUE KEY as a global index with the GLOBAL index option had its word order completely scrambled in 3 sibling files, swapping which term modifies which and mangling "partitioned tables" into a garbled duplicate ("パーティション化[パーティション化されたテーブル]").

  • sql-statements/sql-statement-add-index.md
  • sql-statements/sql-statement-create-index.md
  • sql-statements/sql-statement-create-table.md

Restored each to match the English source's actual meaning: "Setting a PRIMARY KEY (or UNIQUE INDEX/UNIQUE KEY) as a global index using the GLOBAL index option is a TiDB extension for partitioned tables and is not compatible with MySQL."

Note: PR #23509 (still open) happens to touch one of these exact lines (sql-statement-add-index.md) — its change is limited to accidentally converting the line's trailing to a half-width ., unrelated to the actual scrambling this PR fixes. Whichever of the two PRs merges first, the other will need a trivial rebase on this one line.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

The note about setting a PRIMARY KEY/UNIQUE INDEX/UNIQUE KEY as a
global index with the GLOBAL index option had its word order
completely scrambled in 3 sibling files (add-index, create-index,
create-table), swapping which term modifies which and mangling
"partitioned tables" into a garbled duplicate. Restored to match the
English source's actual meaning: "Setting a PRIMARY KEY (or UNIQUE
INDEX/UNIQUE KEY) as a global index using the GLOBAL index option is
a TiDB extension for partitioned tables and is not compatible with
MySQL."

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f99f2bff-bc9a-4203-841d-b9978dcd059c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2026
@yahonda

yahonda commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Superseded — this fix has been committed directly onto #23509's branch instead, per the reviewer's request to keep all #23509 review findings on that PR itself.

@yahonda yahonda closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant