Skip to content

release-8.5: clarify IMPORT INTO format detection by platform and version - #23490

Draft
alastori wants to merge 2 commits into
pingcap:release-8.5from
alastori:docs/import-into-format-detection-8.5
Draft

release-8.5: clarify IMPORT INTO format detection by platform and version#23490
alastori wants to merge 2 commits into
pingcap:release-8.5from
alastori:docs/import-into-format-detection-8.5

Conversation

@alastori

@alastori alastori commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted? (Required)

This PR aligns the IMPORT INTO format documentation on release-8.5 with the behavior released in TiDB v8.5.7 and the current TiDB Cloud behavior:

  • Explains that an explicit FORMAT clause overrides file-extension detection.
  • Qualifies automatic format detection as available in TiDB Self-Managed starting from v8.5.7.
  • Preserves the v8.5.6-and-earlier behavior in which omitting FORMAT uses CSV.
  • Uses platform-specific content so the TiDB Cloud documentation does not expose a Self-Managed patch-version qualifier.
  • Documents case-insensitive detection for .csv, .sql, and .parquet files in the applicable versions and platform.
  • Lists the supported compression suffixes ignored during detection.
  • Clarifies that a missing or unrecognized extension falls back to CSV.
  • Explains that wildcard imports use one format for all matched files and avoids claiming that mixed formats fail during precheck.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

Validation

  • ./scripts/markdownlint sql-statements/sql-statement-import-into.md
  • python3 scripts/file-format-lint.py sql-statements/sql-statement-import-into.md
  • python3 scripts/check-manual-line-breaks.py sql-statements/sql-statement-import-into.md
  • git diff --check
  • Verified that the platform filters retain the v8.5.7 qualifier and earlier-version fallback for TiDB Self-Managed, while TiDB Cloud retains the current automatic-detection wording.
  • Local documentation review gate: APPROVED, with no findings.
  • Direct smoke test against TiDB v8.5.7 and an S3-compatible MinIO endpoint. This validates the TiDB Self-Managed engine behavior for case-insensitive CSV, SQL, and Parquet detection; .gz, .gzip, .zstd, .zst, and .snappy suffixes; missing and unrecognized extension fallback; explicit FORMAT override; and homogeneous wildcard imports.
  • A mixed .csv and .sql wildcard created an import job and failed while parsing the SQL file as CSV. It did not fail during precheck, and the target table remained empty.
  • A live TiDB Cloud cluster was not exercised in this smoke test.

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 337d6c74-c871-4e53-a019-d3789bfb5997

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2026
@alastori

Copy link
Copy Markdown
Collaborator Author

@JQWong7, could you review this documentation update for the IMPORT INTO automatic format-detection behavior implemented in pingcap/tidb#59543?

I smoke-tested the release-8.5 backport on TiDB v8.5.7, including explicit FORMAT, case-insensitive file and compression extensions, CSV fallback, and wildcard imports. The mixed-format case failed during the import rather than during precheck, so this draft avoids that earlier documentation claim.

@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2026
@alastori alastori changed the title release-8.5: document IMPORT INTO automatic format detection release-8.5: clarify IMPORT INTO format detection by platform and version Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant