Skip to content

Keep matrix snapshot assertions active in Release#129

Merged
luisleo526 merged 1 commit into
mainfrom
codex/matrix-snapshot-release-assert-20260722
Jul 22, 2026
Merged

Keep matrix snapshot assertions active in Release#129
luisleo526 merged 1 commit into
mainfrom
codex/matrix-snapshot-release-assert-20260722

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

What changed

Re-enable assert() in test_matrix_snapshot_compat even when the Release toolchain defines NDEBUG.

Why

Copilot correctly noted on #128 that the new compatibility test's assertions became vacuous in Release builds. Debug CI exercised the assertions, so this does not change production behavior; this follow-up makes both Debug and Release gates meaningful.

Validation

  • Release build of test_matrix_snapshot_compat: PASS
  • Release CTest for the target: 1/1 passed
  • Preprocessor check with explicit -DNDEBUG: NDEBUG is absent after processing the test translation unit

Copilot AI review requested due to automatic review settings July 22, 2026 08:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures assert() checks in tests/test_matrix_snapshot_compat remain active even when the test is compiled in Release mode with -DNDEBUG, keeping the snapshot compatibility gate meaningful in both Debug and Release CI.

Changes:

  • Undefines NDEBUG within test_matrix_snapshot_compat so assert() is not compiled out under Release builds.
  • Adds a short comment explaining why this is necessary for the CI compatibility gate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luisleo526
luisleo526 merged commit 89fd3a8 into main Jul 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants