Keep matrix snapshot assertions active in Release#129
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ensures assert() checks in tests/test_matrix_snapshot_compat remain active even when the test is compiled in Release mode with -DNDEBUG, keeping the snapshot compatibility gate meaningful in both Debug and Release CI.
Changes:
- Undefines
NDEBUGwithintest_matrix_snapshot_compatsoassert()is not compiled out under Release builds. - Adds a short comment explaining why this is necessary for the CI compatibility gate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Re-enable
assert()intest_matrix_snapshot_compateven when the Release toolchain definesNDEBUG.Why
Copilot correctly noted on #128 that the new compatibility test's assertions became vacuous in Release builds. Debug CI exercised the assertions, so this does not change production behavior; this follow-up makes both Debug and Release gates meaningful.
Validation
test_matrix_snapshot_compat: PASS-DNDEBUG:NDEBUGis absent after processing the test translation unit