Check the subtracted type when a subtracted mixed accepts a value - #6167
Open
zonuexe wants to merge 1 commit into
Open
Check the subtracted type when a subtracted mixed accepts a value#6167zonuexe wants to merge 1 commit into
zonuexe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#15033
MixedType::accepts(andStrictMixedType, reached onceRuleLevelHelperrewrites an explicitMixedTypeforcheckExplicitMixed) accepted every value unconditionally, so a subtracted mixed likenon-empty-mixedrejected nothing at argument or return boundaries, even though the same subtraction already powered narrowing and reachability (identical.alwaysFalse,if.alwaysTrue, etc.).Acceptance now turns to
Noonly on a definite hit (subtractedType->isSuperTypeOf($given)->yes()), so partial overlaps (e.g. a generalstringintonon-empty-mixed, which may or may not be'') stay accepted — this preservesmixed's usual looseness and is why the fix isn'tisSuperTypeOf(...)->toAcceptsResult().NeverTypeis exempted, mirroringMixedType::isSuperTypeOf.RuleLevelHelper::transformCommonTypenow carries the subtraction through when it converts an explicitMixedTypeintoStrictMixedType, instead of discarding it — otherwise level max stayed silent even withMixedTypefixed.VerbosityLevel::getRecommendedLevelByTypeescalates toprecise()when a subtracted (Strict)MixedType is involved, so messages render the subtraction instead of a bare, uninformativemixed.