ext/iconv/tests/bug76249.phpt: fallback for non-GNU iconv()#22540
Open
orlitzky wants to merge 1 commit into
Open
ext/iconv/tests/bug76249.phpt: fallback for non-GNU iconv()#22540orlitzky wants to merge 1 commit into
orlitzky wants to merge 1 commit into
Conversation
This test fails on musl, where iconv trips over the //IGNORE suffix. It is not obvious that //IGNORE is required to trigger the issue in the first place, but since we are ensuring that a security bug is fixed, it is better to include it where possible. This commit updates the test to append //IGNORE only on the two GNU iconv implementations. Others may support it eventually, but at the moment, despite being part of POSIX, support is inconsistent (as evidenced by musl, if nothing else). In any case, we still test that iconv works with an invalid stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one failure in #22413. The commit message and comment explain the rationale, but here are some references.
//IGNOREwill ignore only untranslatable sequences; invalid sequences are an error instead.//IGNOREshould ignore both invalid and untranslatable sequences. Invalid sequences are not an error in this case.//IGNOREat all.