ext/dom: Fix double-free of namespaces on OOM during parsing.#22539
Draft
devnexen wants to merge 2 commits into
Draft
ext/dom: Fix double-free of namespaces on OOM during parsing.#22539devnexen wants to merge 2 commits into
devnexen wants to merge 2 commits into
Conversation
Fix php#22522 php_dom_ns_compat_mark_attribute_list() cleared node->nsDef only after moving every namespace onto doc->oldNs, so a bailout mid-loop (e.g. OOM) left both lists owning the same namespaces, double-freeing them on teardown. Move each namespace to oldNs before the allocating calls so it is only ever owned by one list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22522
php_dom_ns_compat_mark_attribute_list() cleared node->nsDef only after moving every namespace onto doc->oldNs, so a bailout mid-loop (e.g. OOM) left both lists owning the same namespaces, double-freeing them on teardown. Move each namespace to oldNs before the allocating calls so it is only ever owned by one list.