ext/Intl: Fix IntlDateFormatter offset type validation#22533
Open
LamentXU123 wants to merge 5 commits into
Open
ext/Intl: Fix IntlDateFormatter offset type validation#22533LamentXU123 wants to merge 5 commits into
LamentXU123 wants to merge 5 commits into
Conversation
Girgias
requested changes
Jul 2, 2026
Member
|
Ah the reason they are were using |
Member
Author
Ha. Let's see in the future if I can have time to figure out how the params specifier works in Zend entirely. I still only have a vague idea about how they works that can support me to write new stuffs but I am not confident about refactoring. |
This reverts commit ab4607b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now in
IntlDateFormatter::parseToCalendarwe verify if the offset is a intreproduce here
However, in
IntlDateFormatter::parse()andIntlDateFormatter::localtime()we silently accept offset that is not a int and turns it into 0This will not throws an error, reproduce here
At least for consistence's sake, we should reject non-int
offsetin these functions (This also aligns with previous fixes about avoiding silently casting).