Fix ASGI middleware assignment typing - #473
Closed
hansu650 wants to merge 1 commit into
Closed
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438.
The documented
app.asgi_app = middleware(app.asgi_app)pattern was treated bytype checkers as assignment to a method. This keeps the existing runtime method
unchanged while exposing an assignable ASGI application callable during static
type checking.
The existing middleware test now verifies the assignment without a type-ignore,
and the original OpenTelemetry example from the issue passes mypy.
Validation:
pytest: 256 passedmypyon the OpenTelemetry reproduction: no issues foundgit diff --check: passedFull-project mypy on Windows retains one existing
readline.set_completerplatform error; no new errors are introduced by this change.