fix(tracing): attach errors to non-streaming agent spans - #4075
Closed
workeainc wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Admin <admin@Admins-Mac-mini.local>
Member
|
This overlaps completely with #4070 and #4073, and #4073 is the stronger implementation path because it centralizes the shared exclusion policy and includes broader parity, redaction, and error-preservation coverage. This version imports a private helper from run_loop into the public runtime entrypoint while duplicating the rest of the tracing policy in run.py. It also has the same exception-formatting risk and less boundary coverage. To avoid maintaining two competing fixes, I am going to close this PR in favor of completing the focused changes in #4073. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4070
Validation
uv run pytest tests/test_tracing_errors.py tests/test_tracing_errors_streamed.py -q(20 passed)make formatmake lintmake typecheck(blocked by existing optional-dependency/type issues in sandbox, LiteLLM, NumPy, SQLAlchemy, and AnyLLM modules)AI Usage
AI assistance was used to inspect the issue, propose the focused change, and review the patch. The final implementation and validation were performed in this checkout.