Skip to content

Fix: Fix pipeline#2829

Merged
Koc merged 2 commits into
mainfrom
feature/fix-pipeline
Jul 20, 2026
Merged

Fix: Fix pipeline#2829
Koc merged 2 commits into
mainfrom
feature/fix-pipeline

Conversation

@Koc

@Koc Koc commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR attempts to fix pipeline:

  • fix Psalm for Nextcloud main branch
  • fix undefined steps
  • fail pipeline if Behat tests scenarios contain undefined steps to prevent merging of incomplete tests
  • fix code to pass test scenario Setting permissions on a context share is forbidden
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Koc
Koc force-pushed the feature/fix-pipeline branch 4 times, most recently from 558b8ac to b405818 Compare July 18, 2026 21:46
@Koc
Koc marked this pull request as ready for review July 18, 2026 22:06
@Koc
Koc requested review from blizzz and enjeck as code owners July 18, 2026 22:06
@Koc Koc mentioned this pull request Jul 18, 2026
Open
1 task
@Koc
Koc enabled auto-merge (squash) July 18, 2026 23:11
enjeck
enjeck reviewed Jul 20, 2026
View reviewed changes

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments:

Comment thread lib/Share/SharePageShareDataDecorator.php
Comment thread tests/integration/run.sh Outdated
Comment thread tests/integration/features/bootstrap/FeatureContext.php Outdated
@Koc
Fix: Fix pipeline
29d29d9 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
Koc force-pushed the feature/fix-pipeline branch from 5d14f9f to a83cfd6 Compare July 20, 2026 08:59
@Koc
Fix: Fix pipeline (code review)
0505b4d 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
Koc force-pushed the feature/fix-pipeline branch from a83cfd6 to 0505b4d Compare July 20, 2026 09:26
@Koc
Koc requested a review from enjeck July 20, 2026 09:46
@Koc
Koc merged commit 7dfdd50 into main Jul 20, 2026
75 checks passed
@Koc
Koc deleted the feature/fix-pipeline branch July 20, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes
@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koc @blizzz @enjeck